From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNkhT-0002tS-9m for qemu-devel@nongnu.org; Tue, 17 Feb 2015 11:08:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNkhN-0001Vy-Fm for qemu-devel@nongnu.org; Tue, 17 Feb 2015 11:08:39 -0500 Received: from mx2.parallels.com ([199.115.105.18]:60391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNkhN-00011x-8v for qemu-devel@nongnu.org; Tue, 17 Feb 2015 11:08:33 -0500 Message-ID: <54E36719.8040900@openvz.org> Date: Tue, 17 Feb 2015 19:06:49 +0300 From: "Denis V. Lunev" MIME-Version: 1.0 References: <1424142892-7275-1-git-send-email-mdroth@linux.vnet.ibm.com> <1424142892-7275-4-git-send-email-mdroth@linux.vnet.ibm.com> <54E35DEF.3020309@redhat.com> In-Reply-To: <54E35DEF.3020309@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Michael Roth , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Simon Zolin On 17/02/15 18:27, Eric Blake wrote: > On 02/16/2015 08:14 PM, Michael Roth wrote: >> From: Simon Zolin >> >> Moved the code that sets non-blocking flag on fd into a separate function. >> >> Signed-off-by: Simon Zolin >> Reviewed-by: Roman Kagan >> Signed-off-by: Denis V. Lunev >> CC: Michael Roth >> CC: Eric Blake >> Signed-off-by: Michael Roth >> --- >> qga/commands-posix.c | 31 +++++++++++++++++++++++-------- >> 1 file changed, 23 insertions(+), 8 deletions(-) >> >> diff --git a/qga/commands-posix.c b/qga/commands-posix.c >> index 57409d0..ed527a3 100644 >> --- a/qga/commands-posix.c >> +++ b/qga/commands-posix.c >> @@ -376,13 +376,33 @@ safe_open_or_create(const char *path, const char *mode, Error **errp) >> return NULL; >> } >> >> +static int guest_file_toggle_flags(int fd, int flags, bool set, Error **err) >> +{ > Why are you reinventing qemu_set_nonblock()? > because we are uneducated :) Anyway, qemu_set_nonblock() does not handle error and resides in a strange header aka "include/qemu/sockets.h" Technically I can switch to it immediately. Though error check condition will be lost. What is better at your opinion? a) return error from qemu_set_nonblock()/qemu_set_block() b) drop error check here. The descriptor is just opened and we know that it is valid. I could not imagine real error other than broken descriptor for this exact fcntl. Regards, Den