From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YNzZS-0008S1-Sg
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 03:01:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YNzZO-0005sT-Rv
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 03:01:22 -0500
Received: from mail-we0-f179.google.com ([74.125.82.179]:45650)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YNzZO-0005sO-Lw
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 03:01:18 -0500
Received: by wesw62 with SMTP id w62so3022525wes.12
	for <qemu-devel@nongnu.org>; Wed, 18 Feb 2015 00:01:18 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <54E446CA.1030709@redhat.com>
Date: Wed, 18 Feb 2015 09:01:14 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1424235661-29296-1-git-send-email-david@gibson.dropbear.id.au>
In-Reply-To: <1424235661-29296-1-git-send-email-david@gibson.dropbear.id.au>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Make sysbus EHCI devices ARM only by
	default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>, kraxel@redhat.com, peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org



On 18/02/2015 06:01, David Gibson wrote:
> A number of ARM embedded boards include EHCI USB host controllers which
> appear as directly mapped devices, rather than sitting on a PCI bus.
> 
> At present code to emulate such devices is included whenever EHCI support
> is included.  This patch adjusts teh config options to only include them
> in builds targetting ARM by default.

I'm not even sure if any ARM board is using it, so it could just be
killed I think.  If not,

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  default-configs/arm-softmmu.mak | 1 +
>  hw/usb/Makefile.objs            | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 7671ee2..b00c2e1 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -33,6 +33,7 @@ CONFIG_PFLASH_CFI01=y
>  CONFIG_PFLASH_CFI02=y
>  CONFIG_MICRODRIVE=y
>  CONFIG_USB_MUSB=y
> +CONFIG_USB_EHCI_SYSBUS=y
>  
>  CONFIG_ARM11MPCORE=y
>  CONFIG_A9MPCORE=y
> diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
> index 3fe4dff..0ccd477 100644
> --- a/hw/usb/Makefile.objs
> +++ b/hw/usb/Makefile.objs
> @@ -5,7 +5,8 @@ common-obj-y += libhw.o
>  # usb host adapters
>  common-obj-$(CONFIG_USB_UHCI) += hcd-uhci.o
>  common-obj-$(CONFIG_USB_OHCI) += hcd-ohci.o
> -common-obj-$(CONFIG_USB_EHCI) += hcd-ehci.o hcd-ehci-pci.o hcd-ehci-sysbus.o
> +common-obj-$(CONFIG_USB_EHCI) += hcd-ehci.o hcd-ehci-pci.o
> +common-obj-$(CONFIG_USB_EHCI_SYSBUS) += hcd-ehci-sysbus.o
>  common-obj-$(CONFIG_USB_XHCI) += hcd-xhci.o
>  common-obj-$(CONFIG_USB_MUSB) += hcd-musb.o
>  
>