Re: [Qemu-devel] [RFC PATCH v9 19/23] typedef: add typedef for QemuOpts

[Paolo Bonzini <pbonzini@redhat.com>]

On 18/02/2015 12:57, Pavel Dovgalyuk wrote:
> This patch moves typedefs for QemuOpts and related types
> to qemu/typedefs.h file.
> 
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> ---
>  include/qemu/option.h   |    5 +----
>  include/qemu/typedefs.h |    3 +++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/qemu/option.h b/include/qemu/option.h
> index 58c0157..4b0d336 100644
> --- a/include/qemu/option.h
> +++ b/include/qemu/option.h
> @@ -30,6 +30,7 @@
>  #include "qemu/queue.h"
>  #include "qapi/error.h"
>  #include "qapi/qmp/qdict.h"
> +#include "qemu/typedefs.h"
>  
>  const char *get_opt_name(char *buf, int buf_size, const char *p, char delim);
>  const char *get_opt_value(char *buf, int buf_size, const char *p);
> @@ -44,10 +45,6 @@ void parse_option_size(const char *name, const char *value,
>  bool has_help_option(const char *param);
>  bool is_valid_option_list(const char *param);
>  
> -typedef struct QemuOpt QemuOpt;
> -typedef struct QemuOpts QemuOpts;
> -typedef struct QemuOptsList QemuOptsList;
> -
>  enum QemuOptType {
>      QEMU_OPT_STRING = 0,  /* no parsing (use string as-is)                        */
>      QEMU_OPT_BOOL,        /* on/off                                               */
> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
> index cde3314..a5f8d51 100644
> --- a/include/qemu/typedefs.h
> +++ b/include/qemu/typedefs.h
> @@ -64,6 +64,9 @@ typedef struct QEMUBH QEMUBH;
>  typedef struct QemuConsole QemuConsole;
>  typedef struct QEMUFile QEMUFile;
>  typedef struct QEMUMachine QEMUMachine;
> +typedef struct QemuOpt QemuOpt;
> +typedef struct QemuOpts QemuOpts;
> +typedef struct QemuOptsList QemuOptsList;
>  typedef struct QEMUSGList QEMUSGList;
>  typedef struct QEMUSizedBuffer QEMUSizedBuffer;
>  typedef struct QEMUTimerListGroup QEMUTimerListGroup;
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>