From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO4QA-0003aw-2w for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:12:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YO4Q4-0000tv-Dl for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:12:06 -0500 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:50007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO4Q4-0000tf-7v for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:12:00 -0500 Received: by mail-wi0-f173.google.com with SMTP id bs8so40890174wib.0 for ; Wed, 18 Feb 2015 05:11:59 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54E48F9A.6090505@redhat.com> Date: Wed, 18 Feb 2015 14:11:54 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150218115534.4176.12578.stgit@PASHA-ISP> <20150218115734.4176.66033.stgit@PASHA-ISP> In-Reply-To: <20150218115734.4176.66033.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v9 19/23] typedef: add typedef for QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com On 18/02/2015 12:57, Pavel Dovgalyuk wrote: > This patch moves typedefs for QemuOpts and related types > to qemu/typedefs.h file. > > Signed-off-by: Pavel Dovgalyuk > --- > include/qemu/option.h | 5 +---- > include/qemu/typedefs.h | 3 +++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/qemu/option.h b/include/qemu/option.h > index 58c0157..4b0d336 100644 > --- a/include/qemu/option.h > +++ b/include/qemu/option.h > @@ -30,6 +30,7 @@ > #include "qemu/queue.h" > #include "qapi/error.h" > #include "qapi/qmp/qdict.h" > +#include "qemu/typedefs.h" > > const char *get_opt_name(char *buf, int buf_size, const char *p, char delim); > const char *get_opt_value(char *buf, int buf_size, const char *p); > @@ -44,10 +45,6 @@ void parse_option_size(const char *name, const char *value, > bool has_help_option(const char *param); > bool is_valid_option_list(const char *param); > > -typedef struct QemuOpt QemuOpt; > -typedef struct QemuOpts QemuOpts; > -typedef struct QemuOptsList QemuOptsList; > - > enum QemuOptType { > QEMU_OPT_STRING = 0, /* no parsing (use string as-is) */ > QEMU_OPT_BOOL, /* on/off */ > diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h > index cde3314..a5f8d51 100644 > --- a/include/qemu/typedefs.h > +++ b/include/qemu/typedefs.h > @@ -64,6 +64,9 @@ typedef struct QEMUBH QEMUBH; > typedef struct QemuConsole QemuConsole; > typedef struct QEMUFile QEMUFile; > typedef struct QEMUMachine QEMUMachine; > +typedef struct QemuOpt QemuOpt; > +typedef struct QemuOpts QemuOpts; > +typedef struct QemuOptsList QemuOptsList; > typedef struct QEMUSGList QEMUSGList; > typedef struct QEMUSizedBuffer QEMUSizedBuffer; > typedef struct QEMUTimerListGroup QEMUTimerListGroup; > Reviewed-by: Paolo Bonzini