From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53745)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YO4SV-0005SY-NY
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:14:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YO4SR-0002eM-Ow
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:14:31 -0500
Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:43559)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YO4SR-0002dj-JN
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:14:27 -0500
Received: by mail-wi0-f181.google.com with SMTP id r20so2085553wiv.2
	for <qemu-devel@nongnu.org>; Wed, 18 Feb 2015 05:14:27 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <54E4902E.6030707@redhat.com>
Date: Wed, 18 Feb 2015 14:14:22 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150218115534.4176.12578.stgit@PASHA-ISP>
	<20150218115740.4176.98513.stgit@PASHA-ISP>
In-Reply-To: <20150218115740.4176.98513.stgit@PASHA-ISP>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v9 20/23] replay: initialization and
	deinitialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com



On 18/02/2015 12:57, Pavel Dovgalyuk wrote:
> +void replay_init_timer(void)
> +{

You can call this replay_start.

> +        fprintf(stderr, "Invalid icount rr option: %s\n", rr);
> +        exit(1);
> +    }
> +
> +    fname = qemu_opt_get(opts, "rrfile");
> +    if (!fname) {
> +        fprintf(stderr, "File name not specified for replay\n");
> +        exit(1);

error_report here too, apart from this:

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>