From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO4z6-00074F-Ou for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:48:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YO4z1-0001Pl-NH for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:48:12 -0500 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:36925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO4z1-0001Pb-GX for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:48:07 -0500 Received: by mail-wg0-f45.google.com with SMTP id k14so1270387wgh.4 for ; Wed, 18 Feb 2015 05:48:06 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54E49811.60703@redhat.com> Date: Wed, 18 Feb 2015 14:48:01 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150218115534.4176.12578.stgit@PASHA-ISP> <20150218115627.4176.77066.stgit@PASHA-ISP> In-Reply-To: <20150218115627.4176.77066.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v9 08/23] cpu: replay instructions sequence List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, alex.bennee@linaro.org, afaerber@suse.de, fred.konrad@greensocs.com On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > + if (replay_state.instructions_count == 0) { Please add an assertion that replay_data_kind is EVENT_INSTRUCTION, since you are consuming it below. > + replay_has_unread_data = 0; > + qemu_notify_event();