From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO5Oa-0006h4-Vh for qemu-devel@nongnu.org; Wed, 18 Feb 2015 09:14:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YO5OW-0007EO-I5 for qemu-devel@nongnu.org; Wed, 18 Feb 2015 09:14:32 -0500 Received: from mail-we0-f180.google.com ([74.125.82.180]:45968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO5OW-0007E3-Cq for qemu-devel@nongnu.org; Wed, 18 Feb 2015 09:14:28 -0500 Received: by wesw62 with SMTP id w62so1355030wes.12 for ; Wed, 18 Feb 2015 06:14:28 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54E49E3F.3000000@redhat.com> Date: Wed, 18 Feb 2015 15:14:23 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150218115534.4176.12578.stgit@PASHA-ISP> <20150218115615.4176.14168.stgit@PASHA-ISP> In-Reply-To: <20150218115615.4176.14168.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH v9 06/23] replay: introduce icount event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, alex.bennee@linaro.org, afaerber@suse.de, fred.konrad@greensocs.com On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > +/*! Skips async events until some sync event will be found. */ > +bool skip_async_events(int stop_event); > +/*! Skips async events invocations from the input, > + until required data kind is found. If the requested data is not found > + reports an error and stops the execution. */ > +void skip_async_events_until(unsigned int kind); skip_async_events_until is unused, please remove it. Also, "skip_async_events" is not skipping async events anymore. :) Perhaps rename it to replay_next_event_is? Paolo