From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO5P4-0007TO-Lg for qemu-devel@nongnu.org; Wed, 18 Feb 2015 09:15:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YO5Oz-0007XE-6x for qemu-devel@nongnu.org; Wed, 18 Feb 2015 09:15:02 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:43060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO5Oy-0007Wx-Tp for qemu-devel@nongnu.org; Wed, 18 Feb 2015 09:14:57 -0500 Received: by wesu56 with SMTP id u56so1375087wes.10 for ; Wed, 18 Feb 2015 06:14:56 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54E49E5C.1070905@gnu.org> Date: Wed, 18 Feb 2015 15:14:52 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150218115534.4176.12578.stgit@PASHA-ISP> <20150218115633.4176.67664.stgit@PASHA-ISP> In-Reply-To: <20150218115633.4176.67664.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH v9 09/23] replay: interrupts and exceptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > if (interrupt_request & CPU_INTERRUPT_POLL) { > cs->interrupt_request &= ~CPU_INTERRUPT_POLL; > apic_poll_irq(cpu->apic_state); > + /* Process one interrupt for a single call. > + In record/replay mode each call to this function > + is coupled with an event in the log */ > + if (replay_mode != REPLAY_MODE_NONE) { > + return true; > + } Is it okay to just return true always, even outside replay mode? If so, make it a separate patch. Paolo