From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOAkj-0003MK-RR for qemu-devel@nongnu.org; Wed, 18 Feb 2015 14:57:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOAkf-0002aH-KR for qemu-devel@nongnu.org; Wed, 18 Feb 2015 14:57:45 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56551 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOAkf-0002aD-FF for qemu-devel@nongnu.org; Wed, 18 Feb 2015 14:57:41 -0500 Message-ID: <54E4EEA9.9000405@suse.de> Date: Wed, 18 Feb 2015 20:57:29 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1424167806-8372-1-git-send-email-zhaoshenglong@huawei.com> <1424167806-8372-6-git-send-email-zhaoshenglong@huawei.com> <54E4CFCF.5060408@suse.de> <20150218205157.0fa2ef91@igors-macbook-pro.local> In-Reply-To: <20150218205157.0fa2ef91@igors-macbook-pro.local> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 5/7] target-arm/cpu: Add apic_id property for ARMCPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, wanghaibin.wang@huawei.com, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, Shannon Zhao , pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org Am 18.02.2015 um 20:51 schrieb Igor Mammedov: > On Wed, 18 Feb 2015 18:45:51 +0100 > Andreas F=C3=A4rber wrote: >=20 >> Hi, >> >> Am 17.02.2015 um 11:10 schrieb Shannon Zhao: >>> Add apic_id property for ARMCPU. It can be used for cpu hotplug. >>> >>> Signed-off-by: Shannon Zhao >>> --- >>> target-arm/cpu-qom.h | 1 + >>> target-arm/cpu.c | 77 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++ >>> target-arm/cpu.h | 2 + 3 files changed, 80 insertions(+), 0 >>> deletions(-) >>> >>> diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h >>> index ed5a644..d4560e2 100644 >>> --- a/target-arm/cpu-qom.h >>> +++ b/target-arm/cpu-qom.h >>> @@ -59,6 +59,7 @@ typedef struct ARMCPU { >>> /*< public >*/ >>> =20 >>> CPUARMState env; >>> + uint32_t apic_id; >> >> Can you add a matching @apic_id: documentation entry above the struct? >> >>> =20 >>> /* Coprocessor information */ >>> GHashTable *cp_regs; >>> diff --git a/target-arm/cpu.c b/target-arm/cpu.c >>> index 285947f..9202b07 100644 >>> --- a/target-arm/cpu.c >>> +++ b/target-arm/cpu.c >> [...] >>> @@ -343,6 +407,11 @@ static void arm_cpu_initfn(Object *obj) >>> cpu->cp_regs =3D g_hash_table_new_full(g_int_hash, g_int_equal, >>> g_free, g_free); >>> =20 >>> + object_property_add(obj, "apic-id", "int", >>> + arm_cpuid_get_apic_id, >>> + arm_cpuid_set_apic_id, NULL, NULL, NULL); >> >> The property is correctly called apic-id. Please update the commit >> message, which has it as apic_id (2x). > Is there such thing as apic-id on ARM? Oops, confused it with ACPI... On ARM there's the GIC (or NVIC). There are some IDs that are being represented in the device trees, with jumps between clusters, i.e. 0..3 and 100..103 or so. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)