From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOAnL-0001RF-4L for qemu-devel@nongnu.org; Wed, 18 Feb 2015 15:00:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOAnG-0003Pp-5o for qemu-devel@nongnu.org; Wed, 18 Feb 2015 15:00:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOAnF-0003Os-UO for qemu-devel@nongnu.org; Wed, 18 Feb 2015 15:00:22 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1IK0JW8019107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 18 Feb 2015 15:00:19 -0500 Message-ID: <54E4EF51.70505@redhat.com> Date: Wed, 18 Feb 2015 13:00:17 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424283712-476-1-git-send-email-armbru@redhat.com> In-Reply-To: <1424283712-476-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Xq7QGCaUC6CREK86tsrnO5Vs8sQTBcbao" Subject: Re: [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Xq7QGCaUC6CREK86tsrnO5Vs8sQTBcbao Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/18/2015 11:21 AM, Markus Armbruster wrote: > qerror_report_err() is a transitional interface to help with > converting existing monitor commands to QMP. It should not be used > elsewhere. Replace by error_report_err() in > process_incoming_migration_co(). >=20 > Signed-off-by: Markus Armbruster > --- > Based on > [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err(= ) Reviewed-by: Eric Blake >=20 > migration/migration.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/migration/migration.c b/migration/migration.c > index b3adbc6..6a5e3f9 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -106,8 +106,7 @@ static void process_incoming_migration_co(void *opa= que) > /* Make sure all file formats flush their mutable metadata */ > bdrv_invalidate_cache_all(&local_err); > if (local_err) { > - qerror_report_err(local_err); > - error_free(local_err); > + error_report_err(local_err); > exit(EXIT_FAILURE); > } > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Xq7QGCaUC6CREK86tsrnO5Vs8sQTBcbao Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU5O9SAAoJEKeha0olJ0Nq1fEH/2QrpR12oo0beSm+tIQ7RYoQ PqmIs0jExaxGfXEFW1lrtZECizU1TBiVuo2VEZUztZKJFBG4A8Sl7BfndddNqXM6 ilqQ0fO7Z7WlfsDZF1HS9UIqDNuuRskqr1o96bbKeHIIJkJAy55oc2eHdjLX2xwd AwSItks0hCOxpVLNa13SpIVaYHciQN6fjI+mMSN4KPPVREnW1iK+9BL/t2bWRlXL wbCKrQqHBcbeSrOBXuF9xT6KF8/LfNCGYqO5KgS+Ah+OIynamvXk2otHHITdapxk 1xugbXdh2gpnC9BSYutS2ayH2dRcsZnm8K3L9JSWKbQ60xU+tpmelVaehCWt850= =lnZf -----END PGP SIGNATURE----- --Xq7QGCaUC6CREK86tsrnO5Vs8sQTBcbao--