Re: [Qemu-devel] [PATCH RFC v3 04/14] block: tiny refactoring: minimize hbitmap_(set/reset) usage

[John Snow <jsnow@redhat.com>]

On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
> ---
>   block.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/block.c b/block.c
> index e95a5ae..a127fd2 100644
> --- a/block.c
> +++ b/block.c
> @@ -5670,8 +5670,7 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap,
>
>   void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap)
>   {
> -    assert(bdrv_dirty_bitmap_enabled(bitmap));
> -    hbitmap_reset(bitmap->bitmap, 0, bitmap->size);
> +    bdrv_reset_dirty_bitmap(bitmap, 0, bitmap->size);
>   }
>
>   const char *bdrv_dirty_bitmap_name(const BdrvDirtyBitmap *bitmap)
> @@ -5718,7 +5717,7 @@ static void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector,
>           if (!bdrv_dirty_bitmap_enabled(bitmap)) {
>               continue;
>           }
> -        hbitmap_set(bitmap->bitmap, cur_sector, nr_sectors);
> +        bdrv_set_dirty_bitmap(bitmap, cur_sector, nr_sectors);
>       }
>   }
>
> @@ -5730,7 +5729,7 @@ static void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector,
>           if (!bdrv_dirty_bitmap_enabled(bitmap)) {
>               continue;
>           }
> -        hbitmap_reset(bitmap->bitmap, cur_sector, nr_sectors);
> +        bdrv_reset_dirty_bitmap(bitmap, cur_sector, nr_sectors);
>       }
>   }
>
>

Thanks for this.

Reviewed-by: John Snow <jsnow@redhat.com>