From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOEI1-0003sS-HL for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:44:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOEHy-0003tF-BE for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:44:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOEHy-0003tA-49 for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:44:18 -0500 Message-ID: <54E523CE.4070301@redhat.com> Date: Wed, 18 Feb 2015 18:44:14 -0500 From: John Snow MIME-Version: 1.0 References: <1424268014-13293-1-git-send-email-vsementsov@parallels.com> <1424268014-13293-5-git-send-email-vsementsov@parallels.com> In-Reply-To: <1424268014-13293-5-git-send-email-vsementsov@parallels.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v3 04/14] block: tiny refactoring: minimize hbitmap_(set/reset) usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com, dgilbert@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, amit.shah@redhat.com, den@openvz.org On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/block.c b/block.c > index e95a5ae..a127fd2 100644 > --- a/block.c > +++ b/block.c > @@ -5670,8 +5670,7 @@ void bdrv_reset_dirty_bitmap(BdrvDirtyBitmap *bitmap, > > void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap) > { > - assert(bdrv_dirty_bitmap_enabled(bitmap)); > - hbitmap_reset(bitmap->bitmap, 0, bitmap->size); > + bdrv_reset_dirty_bitmap(bitmap, 0, bitmap->size); > } > > const char *bdrv_dirty_bitmap_name(const BdrvDirtyBitmap *bitmap) > @@ -5718,7 +5717,7 @@ static void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, > if (!bdrv_dirty_bitmap_enabled(bitmap)) { > continue; > } > - hbitmap_set(bitmap->bitmap, cur_sector, nr_sectors); > + bdrv_set_dirty_bitmap(bitmap, cur_sector, nr_sectors); > } > } > > @@ -5730,7 +5729,7 @@ static void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector, > if (!bdrv_dirty_bitmap_enabled(bitmap)) { > continue; > } > - hbitmap_reset(bitmap->bitmap, cur_sector, nr_sectors); > + bdrv_reset_dirty_bitmap(bitmap, cur_sector, nr_sectors); > } > } > > Thanks for this. Reviewed-by: John Snow