From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOEJU-00060o-3U for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:45:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOEJS-0004O4-U1 for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:45:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOEJS-0004Ng-NB for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:45:50 -0500 Message-ID: <54E5242A.90001@redhat.com> Date: Wed, 18 Feb 2015 18:45:46 -0500 From: John Snow MIME-Version: 1.0 References: <1424268014-13293-1-git-send-email-vsementsov@parallels.com> <1424268014-13293-7-git-send-email-vsementsov@parallels.com> In-Reply-To: <1424268014-13293-7-git-send-email-vsementsov@parallels.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v3 06/14] block: add bdrv_next_dirty_bitmap() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com, dgilbert@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, amit.shah@redhat.com, den@openvz.org On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote: > Like bdrv_next() - bdrv_next_dirty_bitmap() is a function to provide > access to private dirty bitmaps list. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 10 ++++++++++ > include/block/block.h | 2 ++ > 2 files changed, 12 insertions(+) > > diff --git a/block.c b/block.c > index aaa08b8..4cca55d 100644 > --- a/block.c > +++ b/block.c > @@ -5649,6 +5649,16 @@ BlockDirtyBitmapInfo *bdrv_query_dirty_bitmap(BlockDriverState *bs, > return info; > } > > +BdrvDirtyBitmap *bdrv_next_dirty_bitmap(BlockDriverState *bs, > + BdrvDirtyBitmap *bitmap) > +{ > + if (bitmap == NULL) { > + return QLIST_FIRST(&bs->dirty_bitmaps); > + } > + > + return QLIST_NEXT(bitmap, list); > +} > + > int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, int64_t sector) > { > if (bitmap) { > diff --git a/include/block/block.h b/include/block/block.h > index f2c62f6..d11d956 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -487,6 +487,8 @@ void bdrv_dirty_bitmap_deserialize_part(BdrvDirtyBitmap *bitmap, > void bdrv_dirty_bitmap_deserialize_zeroes(BdrvDirtyBitmap *bitmap, > uint64_t start, uint64_t count); > void bdrv_dirty_bitmap_deserialize_finish(BdrvDirtyBitmap *bitmap); > +BdrvDirtyBitmap *bdrv_next_dirty_bitmap(BlockDriverState *bs, > + BdrvDirtyBitmap *bitmap); > > HBitmap *bdrv_create_meta_bitmap(BdrvDirtyBitmap *bitmap, > uint64_t granularity); > Reviewed-by: John Snow