From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOEJb-0006DS-SD for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:46:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOEJa-0004R6-LP for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:45:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43807) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOEJa-0004QY-D1 for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:45:58 -0500 Message-ID: <54E52431.3030708@redhat.com> Date: Wed, 18 Feb 2015 18:45:53 -0500 From: John Snow MIME-Version: 1.0 References: <1424268014-13293-1-git-send-email-vsementsov@parallels.com> <1424268014-13293-8-git-send-email-vsementsov@parallels.com> In-Reply-To: <1424268014-13293-8-git-send-email-vsementsov@parallels.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v3 07/14] qapi: add dirty-bitmaps migration capability List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com, dgilbert@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, amit.shah@redhat.com, den@openvz.org On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/migration/migration.h | 1 + > migration/migration.c | 9 +++++++++ > qapi-schema.json | 5 ++++- > 3 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/include/migration/migration.h b/include/migration/migration.h > index f37348b..719875d 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -145,6 +145,7 @@ void migrate_del_blocker(Error *reason); > > bool migrate_rdma_pin_all(void); > bool migrate_zero_blocks(void); > +bool migrate_dirty_bitmaps(void); > > bool migrate_auto_converge(void); > > diff --git a/migration/migration.c b/migration/migration.c > index b3adbc6..68e7478 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -567,6 +567,15 @@ bool migrate_zero_blocks(void) > return s->enabled_capabilities[MIGRATION_CAPABILITY_ZERO_BLOCKS]; > } > > +bool migrate_dirty_bitmaps(void) > +{ > + MigrationState *s; > + > + s = migrate_get_current(); > + > + return s->enabled_capabilities[MIGRATION_CAPABILITY_DIRTY_BITMAPS]; > +} > + > int migrate_use_xbzrle(void) > { > MigrationState *s; > diff --git a/qapi-schema.json b/qapi-schema.json > index 0c31203..70b54ab 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -494,10 +494,13 @@ > # @auto-converge: If enabled, QEMU will automatically throttle down the guest > # to speed up convergence of RAM migration. (since 1.6) > # > +# @dirty-bitmaps: If enabled, QEMU will migrate named dirty bitmaps. (since 2.3) > +# > # Since: 1.2 > ## > { 'enum': 'MigrationCapability', > - 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks'] } > + 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks', > + 'dirty-bitmaps'] } > > ## > # @MigrationCapabilityStatus > Reviewed-by: John Snow