From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YONqI-0007kG-TI
	for qemu-devel@nongnu.org; Thu, 19 Feb 2015 04:56:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YONqF-0006I2-Ox
	for qemu-devel@nongnu.org; Thu, 19 Feb 2015 04:56:22 -0500
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:59835)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YONqF-0006Hx-I5
	for qemu-devel@nongnu.org; Thu, 19 Feb 2015 04:56:19 -0500
Received: by mail-wg0-f42.google.com with SMTP id n12so6216386wgh.1
	for <qemu-devel@nongnu.org>; Thu, 19 Feb 2015 01:56:18 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <54E5B33D.4000803@redhat.com>
Date: Thu, 19 Feb 2015 10:56:13 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <24F20DD4-DD6D-4071-B45F-3CFF81AB419C@gmail.com>
In-Reply-To: <24F20DD4-DD6D-4071-B45F-3CFF81AB419C@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file
	on Mac OS X
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Programmingkid <programmingkidx@gmail.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>



On 18/02/2015 22:09, Programmingkid wrote:
> +	# Take an image and make the image its own icon:
> +	sips -i ../pc-bios/qemu-nsis.ico
> +	# Extract the icon to its own resource file:
> +	DeRez -only icns ../pc-bios/qemu-nsis.ico > tmpicns.rsrc

IIUC sips modifies ../pc-bios/qemu-nsis.ico (adding a resource fork?),
so it's not possible to put it in Makefile.target.  If "sips" is invoked
twice by two different recursive invocations of Makefile.target, bad
things can happen.

I think we can simply distribute tmpicns.rsrc as pc-bios/qemu.rsrc instead.

> +	# append this resource to the file you want to icon-ize.
> +	Rez -append tmpicns.rsrc -o $(QEMU_PROG)
> +
> +	# Use the resource to set the icon.
> +	SetFile -a C $(QEMU_PROG)

These two commands can be added after

$(QEMU_PROG_BUILD): $(all-obj-y) ../libqemuutil.a ../libqemustub.a
        $(call LINK,$^)

instead of adding a new rule.  There is no need for the comments.

Paolo