From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53255)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YOmp5-0001oh-Ex
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 07:36:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YOmp0-0004uo-G3
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 07:36:47 -0500
Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:42687)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YOmp0-0004uk-8B
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 07:36:42 -0500
Received: by mail-wi0-f181.google.com with SMTP id r20so2603313wiv.2
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 04:36:41 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <54E72A54.9040807@redhat.com>
Date: Fri, 20 Feb 2015 13:36:36 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <24F20DD4-DD6D-4071-B45F-3CFF81AB419C@gmail.com>	<54E5B33D.4000803@redhat.com>
	<CAFEAcA9iPCsuFcJReJkAeZMRQDijP-BqoFWAY2V9VC2fQWqisw@mail.gmail.com>
In-Reply-To: <CAFEAcA9iPCsuFcJReJkAeZMRQDijP-BqoFWAY2V9VC2fQWqisw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file
	on Mac OS X
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Programmingkid <programmingkidx@gmail.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>



On 20/02/2015 13:18, Peter Maydell wrote:
> Why not just use the sips --out option to specify a different
> output file? That way we automatically put the current icon
> into the executable, and don't have to update a hand-created
> qemu.rsrc file in git if we change the icon in future (and I
> bet if we don't have the rules for doing this in the makefile
> then nobody will remember how to do it).

I suspect the Windows icon is not a great match for Mac OS X which likes
to have big sizes (48x48 or 128x128).  If you want to generate the .rsrc
file automatically, the right source probably would be the .svg file,
and doing the conversion in the Makefile probably isn't entirely
feasible.  It would need extra build dependency and rounding errors
would make it harder to achieve reproducible builds.

Paolo