From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41153)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YOpte-0000jl-Jw
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:53:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YOptb-0003VL-7U
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:53:42 -0500
Received: from mail-qa0-x232.google.com ([2607:f8b0:400d:c00::232]:58568)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YOptb-0003V0-3o
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:53:39 -0500
Received: by mail-qa0-f50.google.com with SMTP id f12so12996957qad.9
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 07:53:38 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <54E7587E.1000807@twiddle.net>
Date: Fri, 20 Feb 2015 07:53:34 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1424380469-20138-1-git-send-email-rth@twiddle.net>	<1424380469-20138-11-git-send-email-rth@twiddle.net>
	<CABoDooMEpAVHu1eRr_z=XyFfYBozETD-R3LyUUd_sTSvnCfTgQ@mail.gmail.com>
In-Reply-To: <CABoDooMEpAVHu1eRr_z=XyFfYBozETD-R3LyUUd_sTSvnCfTgQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/11] target-arm: Implement fccmp
	branchless
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 02/20/2015 05:57 AM, Laurent Desnogues wrote:
> The problem with this approach is that you'll always call the FP
> compare which might result in FP flags corruption.
> 
> The ARMv8 manual clearly states that the FP compare should only be
> called if the condition holds.

Ah, I hadn't considered that.  Consider this patch dropped.

Thanks,


r~