From: Paolo Bonzini <pbonzini@redhat.com>
To: Programmingkid <programmingkidx@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X
Date: Fri, 20 Feb 2015 18:05:14 +0100 [thread overview]
Message-ID: <54E7694A.1050409@redhat.com> (raw)
In-Reply-To: <4F2700DA-D7EC-4329-9DA6-CCEA27F0E56E@gmail.com>
On 20/02/2015 17:54, Programmingkid wrote:
>> I suspect the Windows icon is not a great match for Mac OS X which likes
>> to have big sizes (48x48 or 128x128).
>
> Definitely true.
>
>> If you want to generate the .rsrc
>> file automatically, the right source probably would be the .svg file,
>> and doing the conversion in the Makefile probably isn't entirely
>> feasible. It would need extra build dependency and rounding errors
>> would make it harder to achieve reproducible builds.
>
> Plus the sips command doesn't work with svg files.
Ok, so I'll apply v3 to my tree as soon as I get a Tested-by. Please
take a look into providing a .rsrc file with larger-sized icons (I think
you can add more than one to a single .rsrc file?) and, when you do
that, document in pc-bios/README how the resources were built.
Thanks,
Paolo
next prev parent reply other threads:[~2015-02-20 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 21:09 [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X Programmingkid
2015-02-19 9:56 ` Paolo Bonzini
2015-02-19 19:34 ` Programmingkid
2015-02-20 12:18 ` Peter Maydell
2015-02-20 12:36 ` Paolo Bonzini
2015-02-20 13:15 ` François Revol
2015-02-20 16:54 ` Programmingkid
2015-02-20 17:05 ` Paolo Bonzini [this message]
2015-02-20 17:32 ` Programmingkid
2015-02-20 17:56 ` Paolo Bonzini
2015-02-20 21:30 ` Programmingkid
2015-02-21 10:05 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E7694A.1050409@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).