From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35287)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YOr18-0006Td-FG
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 12:05:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YOr12-0006nz-6g
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 12:05:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44744)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YOr11-0006nl-VY
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 12:05:24 -0500
Message-ID: <54E7694A.1050409@redhat.com>
Date: Fri, 20 Feb 2015 18:05:14 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <24F20DD4-DD6D-4071-B45F-3CFF81AB419C@gmail.com>
	<54E5B33D.4000803@redhat.com>
	<CAFEAcA9iPCsuFcJReJkAeZMRQDijP-BqoFWAY2V9VC2fQWqisw@mail.gmail.com>
	<54E72A54.9040807@redhat.com>
	<4F2700DA-D7EC-4329-9DA6-CCEA27F0E56E@gmail.com>
In-Reply-To: <4F2700DA-D7EC-4329-9DA6-CCEA27F0E56E@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file
	on Mac OS X
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Programmingkid <programmingkidx@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel qemu-devel <qemu-devel@nongnu.org>



On 20/02/2015 17:54, Programmingkid wrote:
>> I suspect the Windows icon is not a great match for Mac OS X which likes
>> to have big sizes (48x48 or 128x128).
> 
> Definitely true.
> 
>>  If you want to generate the .rsrc
>> file automatically, the right source probably would be the .svg file,
>> and doing the conversion in the Makefile probably isn't entirely
>> feasible.  It would need extra build dependency and rounding errors
>> would make it harder to achieve reproducible builds.
> 
> Plus the sips command doesn't work with svg files. 

Ok, so I'll apply v3 to my tree as soon as I get a Tested-by.  Please
take a look into providing a .rsrc file with larger-sized icons (I think
you can add more than one to a single .rsrc file?) and, when you do
that, document in pc-bios/README how the resources were built.

Thanks,

Paolo