From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 2/3] softmmu: support up to 12 MMU modes
Date: Fri, 20 Feb 2015 11:51:03 -0800 [thread overview]
Message-ID: <54E79027.4030904@twiddle.net> (raw)
In-Reply-To: <1424455040-3335-3-git-send-email-pbonzini@redhat.com>
On 02/20/2015 09:57 AM, Paolo Bonzini wrote:
> + * TCG will have to generate an operand as large as the distance between
> + * tlb_table[0][0] and the tlb_table[NB_MMU_MODES - 1][0].addend. For
Nit: the distance is from the start of env, i.e.
offsetof(CPUArchState, tlb_table[mem_index][0].addend)
not from the start of the table. Not that this particularly invalidates the
rest of your reasoning, but the start of the tlb_table is usually at a
non-trivial (though not huge) offset from the start of CPUArchState.
Otherwise, it looks good.
r~
next prev parent reply other threads:[~2015-02-20 19:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 17:57 [Qemu-devel] [PATCH v2 for-2.3 0/3] Support more than 8 MMU modes, speedup PPC by 10% Paolo Bonzini
2015-02-20 17:57 ` [Qemu-devel] [PATCH 1/3] tcg: add TCG_TARGET_TLB_DISPLACEMENT_BITS Paolo Bonzini
2015-02-20 19:36 ` Richard Henderson
2015-02-23 15:21 ` Alexander Graf
2015-02-23 16:03 ` Richard Henderson
2015-02-20 17:57 ` [Qemu-devel] [PATCH 2/3] softmmu: support up to 12 MMU modes Paolo Bonzini
2015-02-20 19:51 ` Richard Henderson [this message]
2015-02-20 17:57 ` [Qemu-devel] [PATCH 3/3] target-ppc: use separate indices for various translation modes Paolo Bonzini
2015-02-20 19:54 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2015-02-20 12:45 [Qemu-devel] [PATCH for-2.3 0/3] Support more than 8 MMU modes, speedup by 10% Paolo Bonzini
2015-02-20 12:45 ` [Qemu-devel] [PATCH 2/3] softmmu: support up to 12 MMU modes Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E79027.4030904@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).