From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOtbW-0002Y7-QY for qemu-devel@nongnu.org; Fri, 20 Feb 2015 14:51:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOtbQ-00022h-Kb for qemu-devel@nongnu.org; Fri, 20 Feb 2015 14:51:14 -0500 Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]:50321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOtbQ-00022d-HJ for qemu-devel@nongnu.org; Fri, 20 Feb 2015 14:51:08 -0500 Received: by mail-qg0-f45.google.com with SMTP id h3so15874655qgf.4 for ; Fri, 20 Feb 2015 11:51:08 -0800 (PST) Sender: Richard Henderson Message-ID: <54E79027.4030904@twiddle.net> Date: Fri, 20 Feb 2015 11:51:03 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1424455040-3335-1-git-send-email-pbonzini@redhat.com> <1424455040-3335-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1424455040-3335-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] softmmu: support up to 12 MMU modes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: agraf@suse.de On 02/20/2015 09:57 AM, Paolo Bonzini wrote: > + * TCG will have to generate an operand as large as the distance between > + * tlb_table[0][0] and the tlb_table[NB_MMU_MODES - 1][0].addend. For Nit: the distance is from the start of env, i.e. offsetof(CPUArchState, tlb_table[mem_index][0].addend) not from the start of the table. Not that this particularly invalidates the rest of your reasoning, but the start of the tlb_table is usually at a non-trivial (though not huge) offset from the start of CPUArchState. Otherwise, it looks good. r~