From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35487)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1YPrzt-0001vG-Aa
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 07:20:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1YPrzq-00078s-5c
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 07:20:25 -0500
Received: from mail-pd0-f172.google.com ([209.85.192.172]:36246)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1YPrzq-00078c-0R
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 07:20:22 -0500
Received: by pdjp10 with SMTP id p10so25091373pdj.3
	for <qemu-devel@nongnu.org>; Mon, 23 Feb 2015 04:20:21 -0800 (PST)
Message-ID: <54EB1AFD.2060809@ozlabs.ru>
Date: Mon, 23 Feb 2015 23:20:13 +1100
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <1424677796-3044-1-git-send-email-aik@ozlabs.ru>
	<CAFEAcA-Z2kv_K1V1K9pRom6s2ui=hVx+uzOVbqN2aZd4zUQp9Q@mail.gmail.com>
In-Reply-To: <CAFEAcA-Z2kv_K1V1K9pRom6s2ui=hVx+uzOVbqN2aZd4zUQp9Q@mail.gmail.com>
Content-Type: text/plain; charset=koi8-r; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH] utils: Add up_pow_of_two()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

On 02/23/2015 07:54 PM, Peter Maydell wrote:
> On 23 February 2015 at 16:49, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>> This adds a helper to get closest bigger power-of-two value.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>>
>> It is a log2 of round up to power of two. Is there anything like this
>> in QEMU already? Any better name than up_pow_of_two()?
>
> Maybe separate out the "round up to power of 2" and "log2" parts
> into separate functions? If you do that then you could call the
> first one of those pow2ceil(), to match our existing
> pow2floor().


good point, powe2ceil() is enough for me, I'll repost it in a sec. thanks!


-- 
Alexey