From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPt2i-0005tX-KX for qemu-devel@nongnu.org; Mon, 23 Feb 2015 08:27:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPt2e-00087N-Hx for qemu-devel@nongnu.org; Mon, 23 Feb 2015 08:27:24 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:46464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPt2e-00086a-9K for qemu-devel@nongnu.org; Mon, 23 Feb 2015 08:27:20 -0500 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Feb 2015 13:27:17 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 071B61B0806B for ; Mon, 23 Feb 2015 13:27:27 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t1NDRDLs64880850 for ; Mon, 23 Feb 2015 13:27:13 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t1NDRBhc019490 for ; Mon, 23 Feb 2015 06:27:12 -0700 Message-ID: <54EB2AAE.3010009@de.ibm.com> Date: Mon, 23 Feb 2015 14:27:10 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-5-git-send-email-mimu@linux.vnet.ibm.com> <54E73C8F.7000202@suse.de> <20150220160046.4743acc8@bee> <89E3550E-9E2B-4D95-A809-B7C64EBCD7C5@suse.de> <54EB2399.5090500@de.ibm.com> In-Reply-To: <54EB2399.5090500@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Michael Mueller Cc: "linux-s390@vger.kernel.org" , "kvm@vger.kernel.org" , Gleb Natapov , "qemu-devel@nongnu.org" , "linux-kernel@vger.kernel.org" , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson Am 23.02.2015 um 13:56 schrieb Christian Borntraeger: > Am 20.02.2015 um 16:22 schrieb Alexander Graf: >> >> >> >>> Am 20.02.2015 um 16:00 schrieb Michael Mueller : >>> >>> On Fri, 20 Feb 2015 14:54:23 +0100 >>> Alexander Graf wrote: >>> >>>>> >>>>> +/* machine related properties */ >>>>> +typedef struct S390CPUMachineProps { >>>>> + uint16_t class; /* machine class */ >>>>> + uint16_t ga; /* availability number of machine */ >>>>> + uint16_t order; /* order of availability */ >>>>> +} S390CPUMachineProps; >>>>> + >>>>> +/* processor related properties */ >>>>> +typedef struct S390CPUProcessorProps { >>>>> + uint16_t gen; /* S390 CMOS generation */ >>>>> + uint16_t ver; /* version of processor */ >>>>> + uint32_t id; /* processor identification*/ >>>>> + uint16_t type; /* machine type */ >>>>> + uint16_t ibc; /* IBC value */ >>>>> + uint64_t *fac_list; /* list of facilities */ >>>> >>>> Just make this uint64_t fac_list[2]. That way we don't have to track any >>>> messy allocations. >>> >>> It will be something like "uint64_t fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB not >>> just 16 bytes but I will change it. >> >> Why? Do we actually need that many? This is a qemu internal struct. > > The kernel already enabled the 3rd word for z13 support, > https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?id=f8b2dcbd9e6d1479b9b5a9e9e78bbaf783bde819 > > so make it at least 3. This should have been commit 8070361799ae1e3f4ef347bd10f0a508ac10acfb Author: Martin Schwidefsky Date: Mon Oct 6 17:53:53 2014 +0200 s390: add support for vector extension which uses bit 129.