From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPvde-0004nc-Ru for qemu-devel@nongnu.org; Mon, 23 Feb 2015 11:13:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPvde-0003d9-0H for qemu-devel@nongnu.org; Mon, 23 Feb 2015 11:13:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPvdd-0003bo-PC for qemu-devel@nongnu.org; Mon, 23 Feb 2015 11:13:41 -0500 Message-ID: <54EB51AF.30504@redhat.com> Date: Mon, 23 Feb 2015 10:13:35 -0600 From: Wei Huang MIME-Version: 1.0 References: <1424373859-2019-1-git-send-email-rkrcmar@redhat.com> <20150219203101.GA3974@potion.brq.redhat.com> <20150223104546.GE27533@stefanha-thinkpad.redhat.com> <20150223134501.GA2102@potion.brq.redhat.com> <20150223160732.GC2102@potion.brq.redhat.com> In-Reply-To: <20150223160732.GC2102@potion.brq.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Stefan Hajnoczi Cc: qemu-devel , Wei Huang On 02/23/2015 10:07 AM, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > 2015-02-23 14:39+0000, Stefan Hajnoczi: >> Since the typo breaks compilation, it shows that the patch was not >> tested. That makes me nervous. >=20 > (It was based on a tested RHEL7 patch. Upstream allowed for better > code, so I didn't want to push the ugly, yet working, version.) >=20 > Honestly, I was hoping that we don't want to fix this kind of bugs in > QEMU at all, so posting early would have the same effect. >=20 >> Please send v2 after testing the Windows 8 guest. >=20 > Ok, (I don't have the reproducer, so it might take a while,) Given that it is related to one of my BZs, I will help to validate the patch using upstream QEMU. -Wei >=20 > thanks. >=20