From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPxQu-0002sP-Ox for qemu-devel@nongnu.org; Mon, 23 Feb 2015 13:08:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPxQp-0003Mz-Q6 for qemu-devel@nongnu.org; Mon, 23 Feb 2015 13:08:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPxQp-0003Ml-Hb for qemu-devel@nongnu.org; Mon, 23 Feb 2015 13:08:35 -0500 Message-ID: <54EB6C99.9000600@redhat.com> Date: Mon, 23 Feb 2015 13:08:25 -0500 From: Max Reitz MIME-Version: 1.0 References: <1424701661-21241-1-git-send-email-pl@kamp.de> <1424701661-21241-2-git-send-email-pl@kamp.de> In-Reply-To: <1424701661-21241-2-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] block/vpc: optimize vpc_co_get_block_status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, carnold@suse.com, jcody@redhat.com, stefanha@redhat.com On 2015-02-23 at 09:27, Peter Lieven wrote: > *pnum can't be greater than s->block_size / BDRV_SECTOR_SIZE for allocated > sectors since there is always a bitmap in between. > > Signed-off-by: Peter Lieven > --- > block/vpc.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) I would like a comment about this in or above the "if (allocated)" in the do-while loop, but in any case: Reviewed-by: Max Reitz