From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36260)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1YPz7g-0003eS-Lu
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 14:56:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1YPz7f-0004BS-MY
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 14:56:56 -0500
Message-ID: <54EB85D6.1020509@redhat.com>
Date: Mon, 23 Feb 2015 14:56:06 -0500
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1424458395-31906-1-git-send-email-berto@igalia.com>
In-Reply-To: <1424458395-31906-1-git-send-email-berto@igalia.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qerror.h: Swap definitions that were not
 in alphabetical order
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: "qemu-trivial >> QEMU Trivial" <qemu-trivial@nongnu.org>



On 02/20/2015 01:53 PM, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>   include/qapi/qmp/qerror.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
> index 986260f..57a62d4 100644
> --- a/include/qapi/qmp/qerror.h
> +++ b/include/qapi/qmp/qerror.h
> @@ -37,12 +37,12 @@ void qerror_report_err(Error *err);
>   #define QERR_BASE_NOT_FOUND \
>       ERROR_CLASS_GENERIC_ERROR, "Base '%s' not found"
>
> -#define QERR_BLOCK_JOB_NOT_READY \
> -    ERROR_CLASS_GENERIC_ERROR, "The active block job for device '%s' cannot be completed"
> -
>   #define QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED \
>       ERROR_CLASS_GENERIC_ERROR, "Block format '%s' used by device '%s' does not support feature '%s'"
>
> +#define QERR_BLOCK_JOB_NOT_READY \
> +    ERROR_CLASS_GENERIC_ERROR, "The active block job for device '%s' cannot be completed"
> +
>   #define QERR_BUS_NO_HOTPLUG \
>       ERROR_CLASS_GENERIC_ERROR, "Bus '%s' does not support hotplugging"
>
>

Cc: qemu-trivial@nongnu.org

Reviewed-by: John Snow <jsnow@redhat.com>