From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1YQ106-0002rO-8b
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 16:57:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1YQ102-00041a-9M
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 16:57:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33497)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1YQ102-00041M-1y
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 16:57:10 -0500
Message-ID: <54EBA219.8060804@redhat.com>
Date: Mon, 23 Feb 2015 14:56:41 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1423710438-14377-1-git-send-email-wency@cn.fujitsu.com>
	<1423710438-14377-3-git-send-email-wency@cn.fujitsu.com>
In-Reply-To: <1423710438-14377-3-git-send-email-wency@cn.fujitsu.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="hauDPAXe2f0unOGbqDcQDGDQI43d9Sksb"
Subject: Re: [Qemu-devel] [RFC PATCH 02/14] quorom: add a new read pattern
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--hauDPAXe2f0unOGbqDcQDGDQI43d9Sksb
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 02/11/2015 08:07 PM, Wen Congyang wrote:
> To block replication, we only need to read from the first child.

s/quorom/quorum/ in the subject line

s/To block/For block/

>=20
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  block/quorum.c       | 5 +++--
>  qapi/block-core.json | 4 +++-
>  2 files changed, 6 insertions(+), 3 deletions(-)

> +++ b/qapi/block-core.json
> @@ -1618,9 +1618,11 @@
>  #
>  # @fifo: read only from the first child that has not failed
>  #
> +# @first: read only from the first child
> +

Missing a 'since 2.3' designation.  Otherwise looks okay.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--hauDPAXe2f0unOGbqDcQDGDQI43d9Sksb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJU66IZAAoJEKeha0olJ0NqAyQH/1ITG3rWyyycYqnQJIj7CLYO
Pc9c2MaKUf5qVR8APZPixGQZCOvrghwo977Vm3pkRRgYCVAz4+zleJDTyRPj4Y0n
AlaBvGsMmlNXawLCe13uj4UKqf7TZVMGHtjmkcFCU+hgxLFE5y6X70K4T7OSuXTd
dqe49BdObUNHBljfQ6y9gthUflZ3eXaQhujSGeD0x5hQ9KC8xyk5JKt+3zAiXWon
Dj8vZneebD/OIeYwoy+xxPbOQC32J3E005g2jjuBDHGBSARh+m1sYZBIv95KcsaQ
zK0+du5nhwLufjmltRL5v/uFSXCSpmQVBKgwR3N4jQTs4vmIc5xJkFzrQn3f6rM=
=TNd+
-----END PGP SIGNATURE-----

--hauDPAXe2f0unOGbqDcQDGDQI43d9Sksb--