From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43093)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YQ1Ul-0002RB-Pg
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 17:28:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YQ1Ug-00028k-1v
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 17:28:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44516)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YQ1Uf-00028W-OY
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 17:28:49 -0500
Message-ID: <54EBA961.1080400@redhat.com>
Date: Mon, 23 Feb 2015 17:27:45 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1423710438-14377-1-git-send-email-wency@cn.fujitsu.com>
	<1423710438-14377-13-git-send-email-wency@cn.fujitsu.com>
In-Reply-To: <1423710438-14377-13-git-send-email-wency@cn.fujitsu.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 12/14] Add disk buffer for block
	replication
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>

On 2015-02-11 at 22:07, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>   block/Makefile.objs    |   1 +
>   block/blkcolo-buffer.c | 324 +++++++++++++++++++++++++++++++++++++++++++++++++
>   block/blkcolo.h        |  35 ++++++
>   3 files changed, 360 insertions(+)
>   create mode 100644 block/blkcolo-buffer.c
>   create mode 100644 block/blkcolo.h

In general: Can you please add some prefix to the non-static functions, 
like colo_*?

As for the design questions regarding this block driver, I should 
probably leave that to Fam and John (because they seemed to have an idea 
how to approach the issue at hand using a different implementation, 
based on functionality that's already (or close to become) part of qemu).

Therefore, I'm hesitating to review this patch (and the following ones) 
until you've reached a conclusion on how to proceed.

Max