From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47157)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YQ1bP-0000Dq-SF
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 17:35:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YQ1bL-0005u2-Gb
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 17:35:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56503)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YQ1bL-0005ts-98
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 17:35:43 -0500
Message-ID: <54EBAB32.5050205@redhat.com>
Date: Mon, 23 Feb 2015 17:35:30 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1423710438-14377-1-git-send-email-wency@cn.fujitsu.com>
	<1423710438-14377-15-git-send-email-wency@cn.fujitsu.com>
In-Reply-To: <1423710438-14377-15-git-send-email-wency@cn.fujitsu.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 14/14] COLO: implement a new block
	driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>

On 2015-02-11 at 22:07, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>   block/Makefile.objs |   2 +-
>   block/blkcolo.c     | 409 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 410 insertions(+), 1 deletion(-)
>   create mode 100644 block/blkcolo.c

Seeing what you want to use the BlockBackend for (which is, set up an 
NBD server): I think it's best to create the BlockBackend the moment the 
NBD server is created, and destroy it the moment the NBD server is 
stopped (that is, create it in colo_svm_init() and destroy it in 
colo_svm_fini()).

Max