From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQ9Bi-0001uY-Pg for qemu-devel@nongnu.org; Tue, 24 Feb 2015 01:41:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQ9Bd-0004YG-2Y for qemu-devel@nongnu.org; Tue, 24 Feb 2015 01:41:46 -0500 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:33774 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQ9Bc-0004XN-Mr for qemu-devel@nongnu.org; Tue, 24 Feb 2015 01:41:40 -0500 Message-ID: <54EC1D20.5030600@kamp.de> Date: Tue, 24 Feb 2015 07:41:36 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1424701661-21241-1-git-send-email-pl@kamp.de> <1424701661-21241-2-git-send-email-pl@kamp.de> <54EB6C99.9000600@redhat.com> In-Reply-To: <54EB6C99.9000600@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] block/vpc: optimize vpc_co_get_block_status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: kwolf@redhat.com, carnold@suse.com, jcody@redhat.com, stefanha@redhat.com Am 23.02.2015 um 19:08 schrieb Max Reitz: > On 2015-02-23 at 09:27, Peter Lieven wrote: >> *pnum can't be greater than s->block_size / BDRV_SECTOR_SIZE for allocated >> sectors since there is always a bitmap in between. >> >> Signed-off-by: Peter Lieven >> --- >> block/vpc.c | 15 ++++++--------- >> 1 file changed, 6 insertions(+), 9 deletions(-) > > I would like a comment about this in or above the "if (allocated)" in the do-while loop, but in any case: Will add in v2. Peter > > Reviewed-by: Max Reitz