From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47890)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1YQBYT-00086C-SY
	for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:13:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1YQBYP-0001Ar-8p
	for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:13:25 -0500
Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:43300)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1YQBYO-0001AK-UM
	for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:13:21 -0500
Received: from /spool/local
	by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Tue, 24 Feb 2015 09:13:18 -0000
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8B4CF1B08070
	for <qemu-devel@nongnu.org>; Tue, 24 Feb 2015 09:13:31 +0000 (GMT)
Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com
	[9.149.37.250])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t1O9DGCD5570988
	for <qemu-devel@nongnu.org>; Tue, 24 Feb 2015 09:13:16 GMT
Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t1O9DGFa024396
	for <qemu-devel@nongnu.org>; Tue, 24 Feb 2015 02:13:16 -0700
Message-ID: <54EC40AB.3020306@de.ibm.com>
Date: Tue, 24 Feb 2015 10:13:15 +0100
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1424087278-49393-1-git-send-email-tumanova@linux.vnet.ibm.com>
In-Reply-To: <1424087278-49393-1-git-send-email-tumanova@linux.vnet.ibm.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 0/5] Geometry and blocksize detection
	for backing devices.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>, Public KVM Mailing List <qemu-devel@nongnu.org>
Cc: kwolf@redhat.com, thuth@linux.vnet.ibm.com, armbru@redhat.com, mihajlov@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com

Am 16.02.2015 um 12:47 schrieb Ekaterina Tumanova:
> Updates v6 -> v7:
> 
> Fix  
> 1. Set default blocksizes via blkconf_blocksizes call in ide_dev_initfn
> and scsi_hd_realise before using these values.
> 2. Remove asserts in bdrv functions, check drv for being NULL instead.
> 3. Adjust logic in blkconf_blocksizes to use command-line blocksize values
> (if they are in place) without any dependency on block backend probing.
> 
> p.s. Make check now suceeds.
> 
> p.p.s. Stefan, please notify if you need to re-review.


v7 retested
- make check on x86_64/s390x 
- dasd geo/blocksize/partition detection