From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQIHS-0008WQ-DQ for qemu-devel@nongnu.org; Tue, 24 Feb 2015 11:24:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQIHP-00079w-6q for qemu-devel@nongnu.org; Tue, 24 Feb 2015 11:24:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQIHO-00079k-Vg for qemu-devel@nongnu.org; Tue, 24 Feb 2015 11:24:15 -0500 Message-ID: <54ECA5A8.3070304@redhat.com> Date: Tue, 24 Feb 2015 09:24:08 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424732339-11237-1-git-send-email-mreitz@redhat.com> <87bnkjlk4h.fsf@blackfin.pond.sub.org> <54EC849C.4000400@redhat.com> In-Reply-To: <54EC849C.4000400@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6GKWgxvLItxV7VX4V81Spfmcn1EM1ii4a" Subject: Re: [Qemu-devel] [PATCH] virtio-scsi: Allocate op blocker reason before blocking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Markus Armbruster Cc: Paolo Bonzini , qemu-devel@nongnu.org, Anthony Liguori , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6GKWgxvLItxV7VX4V81Spfmcn1EM1ii4a Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/24/2015 07:03 AM, Max Reitz wrote: > On 2015-02-24 at 04:43, Markus Armbruster wrote: >> Max Reitz writes: >> >>> s->blocker is really only used in hw/scsi/virtio-scsi.c; the only pla= ces >>> where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is >>> allocated and when it is freed. That does not make a whole lot of sen= se >>> (and is actually wrong because this leads to s->blocker potentially >>> being NULL when blk_op_block_all() is called in virtio-scsi.c), so mo= ve >>> the allocation and destruction of s->blocker to blk_op_block_all() an= d >>> blk_op_unblock_all() in virtio-scsi.c, respectively. >>> >> Why do you put your nice reproducer below the --- divider? I rather >> like bug fixing commits come with reproducers in the commit message. As do I :) >> >> [...] >=20 > Because then I'm afraid that Eric complains because I used echo -e > instead of printf. I might point out the non-portability, but for a commit message, I'm perfectly fine leaving a non-portable construct in place. I'm only going to ask for a respin if 'echo -e' is used in the patch body. >=20 > Seriously speaking, I don't mind putting it into the commit message. > I'll wait for reviews on the change itself, and then either send a v2 > with the reproducer included in the commit message or hope for a > maintainer to fix it up himself (which I'd be totally fine with *hint > hint*). Up to the maintainer on that front, but if it helps, then with the amended commit message: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6GKWgxvLItxV7VX4V81Spfmcn1EM1ii4a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU7KWpAAoJEKeha0olJ0NqDwMH/1P1M7c4woWM898+EjjSwzAe vCZQbV0DWhvVKZpTNsCQmTb5YTC92RiuAlqX1Al61GmTevNNg2IW4ann/hINIBhe eYhe9kGdDOQzlgWwQLjNqq0Zj0VN9YLzWfjY9nWAxpcI5F2OI+01InZ6bU7z6Pry Fc6jE3qzJu/LoLruaOrnZfDOHhArbuzgV0ZeQlzC1lxJrc5fF+UxxCL6Cq7QxgR8 G4CnYeR1SEwzTSJEONgy/5jIOlwMg0QpYrPbRGOSPhw/47694vZj2QhqPQ9KpYcd +2fGwnFXCQm+4nN2iwMdAJKTV4tx7nsh0cVwXmmKg5Q4DQ65CD/8aAcarN5naMo= =SNxW -----END PGP SIGNATURE----- --6GKWgxvLItxV7VX4V81Spfmcn1EM1ii4a--