From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQIl9-00086H-Rm for qemu-devel@nongnu.org; Tue, 24 Feb 2015 11:55:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQIl5-0000Ue-LN for qemu-devel@nongnu.org; Tue, 24 Feb 2015 11:54:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQIl5-0000UW-Dd for qemu-devel@nongnu.org; Tue, 24 Feb 2015 11:54:55 -0500 Message-ID: <54ECACB5.9030406@redhat.com> Date: Tue, 24 Feb 2015 09:54:13 -0700 From: Eric Blake MIME-Version: 1.0 References: <14cbc4c207ba6451894101aae39d146144a3c6dc.1423842044.git.berto@igalia.com> In-Reply-To: <14cbc4c207ba6451894101aae39d146144a3c6dc.1423842044.git.berto@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8kFDRAJG3rtgRM5v07rdlbshkEIng1vdU" Subject: Re: [Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8kFDRAJG3rtgRM5v07rdlbshkEIng1vdU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/13/2015 09:06 AM, Alberto Garcia wrote: > Replace also throttle_group_compare() with throttle_group_get_name() >=20 > Signed-off-by: Alberto Garcia > --- > block.c | 2 +- > block/qapi.c | 5 +++++ > block/throttle-groups.c | 14 ++++---------- > hmp.c | 6 ++++-- > include/block/throttle-groups.h | 2 +- > qapi/block-core.json | 4 +++- > 6 files changed, 18 insertions(+), 15 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -255,6 +255,8 @@ > # > # @iops_size: #optional an I/O size in bytes (Since 1.7) > # > +# @group: #optional throttle group name (Since 2.3) > +# > # @cache: the cache mode used for the block device (since: 2.3) Ugh - now I'm getting confused by context. Looks like 7/9 touched block_set_io_throttle, and 9/9 touches BlockDeviceInfo. > # > # @write_threshold: configured write threshold for the device. > @@ -274,7 +276,7 @@ > '*bps_max': 'int', '*bps_rd_max': 'int', > '*bps_wr_max': 'int', '*iops_max': 'int', > '*iops_rd_max': 'int', '*iops_wr_max': 'int', > - '*iops_size': 'int', 'cache': 'BlockdevCacheInfo', > + '*iops_size': 'int', '*group': 'str', 'cache': 'BlockdevCa= cheInfo', > 'write_threshold': 'int' } } > =20 Questions - with this series in place, is it ever possible to have throttling parameters without a throttle group name? Do we auto-generate a group name (perhaps based on the node name) for any throttling parameters set without reference to a group name? When using block_set_io_throttle, is it legal to pass parameters (like bps_max) and a group name at the same time, and if so, what happens if there is already a throttle group by that name? Is there a command that can return the list of all throttle group names? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8kFDRAJG3rtgRM5v07rdlbshkEIng1vdU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU7Ky1AAoJEKeha0olJ0NqZdMH/15cJvtq+nhMRQjIg8L/M7Yf y/QTxuhcNuWAsZc6bgwdci4wxUGhqj0bTez3PpYXYDc2BcVvRVFsP+DDNp3QD3lE 0uterRTi2OGdVxyTBfiGwOsaarUONKyq+ymCWEudayqWZ7c0AICaUWpsWLnbpYeu 5TETqZJ8oHRGNo5QP9UnuOOWYtHm4HyihqUvuKJdeXV7Fqq9328sskwrMYSZH+3M MvmlAfIjuRKFWO+6fvVuxBfm3VKQVFCuAbz73mGQEScXwnl7IUhSOcPiLhnTEmL1 rStCFjpHJ9CjSP71h8fd7EIQaY8nKbHEWqfarzgBrXjofKPHsZYYwDoUXQEjjCk= =9VdG -----END PGP SIGNATURE----- --8kFDRAJG3rtgRM5v07rdlbshkEIng1vdU--