From: Chris Metcalf <cmetcalf@ezchip.com>
To: Chen Gang S <gang.chen@sunrus.com.cn>,
Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <rth@redhat.com>,
"walt@tilera.com" <walt@tilera.com>,
Riku Voipio <riku.voipio@iki.fi>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully
Date: Tue, 24 Feb 2015 13:18:58 -0500 [thread overview]
Message-ID: <54ECC092.7030105@ezchip.com> (raw)
In-Reply-To: <54ECB3ED.7030100@sunrus.com.cn>
On 2/24/2015 12:25 PM, Chen Gang S wrote:
> For me, if the raw integer is only used once, we needn't define a macro
> for it (instead of, we can give a comment for it).
The advantage of names even in this case is that you can group all the
macro definitions in one place where they are easy to read and review.
Then later when you use them they are self-documenting. And if you
are going to use opcode_tilegx.h anyway, you get the names "for free".
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
next prev parent reply other threads:[~2015-02-24 18:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 7:53 [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully Chen Gang S
2015-02-24 8:07 ` Chen Gang S
2015-02-24 14:21 ` Chris Metcalf
2015-02-24 14:38 ` Peter Maydell
2015-02-24 15:39 ` Chen Gang S
2015-02-24 16:42 ` Richard Henderson
2015-02-24 17:08 ` Chen Gang S
2015-02-24 16:31 ` Chen Gang S
2015-02-24 16:46 ` Chris Metcalf
2015-02-24 17:25 ` Chen Gang S
2015-02-24 18:18 ` Chris Metcalf [this message]
2015-02-25 1:01 ` Chen Gang S
2015-02-24 17:55 ` Richard Henderson
2015-02-25 3:40 ` Chen Gang S
2015-02-25 17:19 ` Richard Henderson
2015-02-26 1:44 ` Chen Gang S
2015-02-26 16:31 ` Richard Henderson
2015-02-26 23:30 ` Chen Gang S
2015-02-27 3:01 ` Chris Metcalf
2015-02-27 3:41 ` Chen Gang S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ECC092.7030105@ezchip.com \
--to=cmetcalf@ezchip.com \
--cc=gang.chen@sunrus.com.cn \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@redhat.com \
--cc=walt@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).