From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQK4m-0008Hv-IZ for qemu-devel@nongnu.org; Tue, 24 Feb 2015 13:19:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQK4j-0004gb-Ah for qemu-devel@nongnu.org; Tue, 24 Feb 2015 13:19:20 -0500 Received: from mail-db3on0080.outbound.protection.outlook.com ([157.55.234.80]:23520 helo=emea01-db3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQK4i-0004g8-Ro for qemu-devel@nongnu.org; Tue, 24 Feb 2015 13:19:17 -0500 Message-ID: <54ECC092.7030105@ezchip.com> Date: Tue, 24 Feb 2015 13:18:58 -0500 From: Chris Metcalf MIME-Version: 1.0 References: <54EC2DEE.8050809@sunrus.com.cn> <54EC88D6.3060402@ezchip.com> <54ECA746.8030804@sunrus.com.cn> <54ECAB00.6000501@ezchip.com> <54ECB3ED.7030100@sunrus.com.cn> In-Reply-To: <54ECB3ED.7030100@sunrus.com.cn> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-tilegx: Execute _start and reach to __libc_start_main successfully List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Gang S , Peter Maydell , Richard Henderson , "walt@tilera.com" , Riku Voipio Cc: qemu-devel On 2/24/2015 12:25 PM, Chen Gang S wrote: > For me, if the raw integer is only used once, we needn't define a macro > for it (instead of, we can give a comment for it). The advantage of names even in this case is that you can group all the macro definitions in one place where they are easy to read and review. Then later when you use them they are self-documenting. And if you are going to use opcode_tilegx.h anyway, you get the names "for free". -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com