From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQNDK-0002Gg-0J for qemu-devel@nongnu.org; Tue, 24 Feb 2015 16:40:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQNDE-0002i8-RL for qemu-devel@nongnu.org; Tue, 24 Feb 2015 16:40:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQNDE-0002hy-Ih for qemu-devel@nongnu.org; Tue, 24 Feb 2015 16:40:16 -0500 Message-ID: <54ECEFBD.8000200@redhat.com> Date: Tue, 24 Feb 2015 14:40:13 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424810331-25657-1-git-send-email-samuel.pitoiset@gmail.com> In-Reply-To: <1424810331-25657-1-git-send-email-samuel.pitoiset@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="McVuo84mmqVXom7BlFghBoVlaaRQIoMGR" Subject: Re: [Qemu-devel] [PATCH] vfio: allow to disable MMAP per device with -x-mmap=off option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Samuel Pitoiset , qemu-devel@nongnu.org Cc: alex.williamson@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --McVuo84mmqVXom7BlFghBoVlaaRQIoMGR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/24/2015 01:38 PM, Samuel Pitoiset wrote: > Disabling MMAP support uses the slower read/write accesses but allows t= o > trace all MMIO accesses, which is not good for performance, but very > useful for reverse engineering PCI drivers. This option allows to > disable MMAP per device without a compile-time change. >=20 > Signed-off-by: Samuel Pitoiset > --- > hw/vfio/common.c | 2 +- > hw/vfio/pci.c | 1 + > include/hw/vfio/vfio-common.h | 2 +- > 3 files changed, 3 insertions(+), 2 deletions(-) > +++ b/hw/vfio/pci.c > @@ -3456,6 +3456,7 @@ static Property vfio_pci_dev_properties[] =3D { > DEFINE_PROP_BIT("x-vga", VFIOPCIDevice, features, > VFIO_FEATURE_ENABLE_VGA_BIT, false), > DEFINE_PROP_INT32("bootindex", VFIOPCIDevice, bootindex, -1), > + DEFINE_PROP_BOOL("x-mmap", VFIOPCIDevice, vbasedev.allow_mmap, tru= e), Naming it 'x-mmap' implies it is experimental and may be removed someday. Is there any reason why you are not proposing it as a permanent knob? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --McVuo84mmqVXom7BlFghBoVlaaRQIoMGR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU7O+9AAoJEKeha0olJ0NqHIkH/A42xKTbfZFAHO6LvtFvoXV1 4h7wXcrMWnIgHY7gVlPlFgUHml/DdkJtUoZOFNEdwudtKgJTwe4if57HO7PtBFgL ZDx15E1a9t91TgbOwbVawD7rEuv+t/Tp4P6Q277YrIuA64XBKk6dBQqR52o2ivSp 6a5TiNSo5YqMMddM6hdI83aIyohMMOzn6Kl0Ism0rjvkfyk/n+a3HS1MosJauDQP t6FrlMUduTQLZZ5iBnUoV7PpeNgyzXZaaBLLmmTo2zJG+8V+1ppP/lu1E+cdanI5 pb0+nrhD+JITE2tIia3jsXQje8mrhGTyfwDP+HV+WDPryPgAOZuGKEH4B4VX4rU= =3r1O -----END PGP SIGNATURE----- --McVuo84mmqVXom7BlFghBoVlaaRQIoMGR--