From: Eric Blake <eblake@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-devel@nongnu.org, Samuel Pitoiset <samuel.pitoiset@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] vfio: allow to disable MMAP per device with -x-mmap=off option
Date: Tue, 24 Feb 2015 20:04:44 -0700 [thread overview]
Message-ID: <54ED3BCC.6010609@redhat.com> (raw)
In-Reply-To: <1424814826.12626.97.camel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On 02/24/2015 02:53 PM, Alex Williamson wrote:
>>
>> Naming it 'x-mmap' implies it is experimental and may be removed
>> someday. Is there any reason why you are not proposing it as a
>> permanent knob?
>
> I actually suggested the x- prefix to Samuel because I don't think this
> is a mode that we want to officially support. It's useful for enabling
> tracing, but it's possible that doing this will break timing sensitive
> devices. I therefore don't really want to put it at the fingertips of
> the average user.
Works for me :)
> If we have a reason to call it supported at some
> point later, we can always change it. Thanks,
Yep, that's always an option. Easier to make something stable later
when it proved worthwhile, than it is to regret making it stable now.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-02-25 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 20:38 [Qemu-devel] [PATCH] vfio: allow to disable MMAP per device with -x-mmap=off option Samuel Pitoiset
2015-02-24 21:40 ` Eric Blake
2015-02-24 21:53 ` Alex Williamson
2015-02-25 3:04 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ED3BCC.6010609@redhat.com \
--to=eblake@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.pitoiset@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).