From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQswe-0000sv-Gb for qemu-devel@nongnu.org; Thu, 26 Feb 2015 02:33:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQswY-0008Pu-PN for qemu-devel@nongnu.org; Thu, 26 Feb 2015 02:33:16 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:53381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQswX-0008ED-VJ for qemu-devel@nongnu.org; Thu, 26 Feb 2015 02:33:10 -0500 Message-ID: <54EECBFF.7060604@huawei.com> Date: Thu, 26 Feb 2015 15:32:15 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1424167806-8372-1-git-send-email-zhaoshenglong@huawei.com> <54E4C99F.7070403@redhat.com> In-Reply-To: <54E4C99F.7070403@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/7] hw/arm/virt: Add cpu-add way cpu hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Huang , qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com, christoffer.dall@linaro.org, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, imammedo@redhat.com, hanjun.guo@linaro.org, mst@redhat.com, lersek@redhat.com Cc: wanghaibin.wang@huawei.com, hangaohuai@huawei.com, peter.huangpeng@huawei.com On 2015/2/19 1:19, Wei Huang wrote: > Nice work. I will help review the patches. > Thanks for your help :-) > Other than the CPU hotplug support, we are also seeking the guest VM > powerdown support via ACPI. This feature is important for management > tool to control guest VMs. In fact I had a similar GPIO patch for > powerdown recently. Given that you already posted a more complete > version, I wonder if you can add this feature to your patchset? FYI, I > attached my powerdown patch in this email. Here is a brief list of items: > > * DSDT description of power button (to-be-done) > * Hook up with qemu_qemu_register_powerdown_notifier() with the GPIO IRQ > > Feel free to add my name as signed-off-by in this feature if you decide > to add it. Yes, I think the powerdown support is very useful, but maybe this feature can be added by a new patchset as this patchset cares about CPU hotplug. We can add powerdown, memory hotplug, cpu remove and memory remove support step by step if the approach of this patchset is accepted. I can make a patch to add powerdown support based on this patchset and your attached patch if you want to test this feature. How do you think about this? -- Thanks, Shannon