From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQur2-0008Om-HX for qemu-devel@nongnu.org; Thu, 26 Feb 2015 04:35:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQuqx-00010f-14 for qemu-devel@nongnu.org; Thu, 26 Feb 2015 04:35:36 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44558 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQuqw-00010U-QA for qemu-devel@nongnu.org; Thu, 26 Feb 2015 04:35:30 -0500 Message-ID: <54EEE8E0.40301@suse.de> Date: Thu, 26 Feb 2015 10:35:28 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <54EBD30C.1040902@cn.fujitsu.com> <54ECAD4D.9030506@suse.de> <54ED9CC4.90102@cn.fujitsu.com> In-Reply-To: <54ED9CC4.90102@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 00/10] cpu: add device_add foo-x86_64-cpu support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan , Gu Zheng Cc: Zhu Guihua , Bharata B Rao , qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, anshul.makkar@profitbricks.com, imammedo@redhat.com Hi, Am 25.02.2015 um 10:58 schrieb Chen Fan: > On 02/25/2015 12:56 AM, Andreas F=E4rber wrote: >> Am 24.02.2015 um 02:25 schrieb Gu Zheng: >>> The issues you commented in the previous version have been fixed in >>> this one. >> What I have repeatedly rejected is "device_add foo-x86_64-cpu". This i= s >> still in 00/10 and 09/10. Most of the actual changes however do look t= o >> be going in the right direction of making 'realize' work as expected f= or >> foo-x86_64-cpu. >> >> As for the socket-based device_add I mentioned, I had pushed a work >> branch qom-cpu-x86 and had some off-list discussions for some of the >> other architectures but did not submit it as an RFC yet. What I am sti= ll >> working on is dynamic properties to allocate cores (threads TBD) for >> "device_add x86_64-cpu-socket,cores=3Dn". > Can you explain all your thoughts about cpu hotplug feature with > socket-based, > or how goals do you want to see? Basically I am implementing Anthony's suggestion from a year or two back, that is moving towards using real building blocks such as Xeon-E5-4242 as shortcut for a 6-core, 2-HT device, ultimately replacing -cpu. Think of what can be plugged in real servers - a socket is atomic in reality, you can't add cores or hyperthreads dynamically. And the QOM realize model then forces me to use child<> properties inside the socket object for consistent recursive processing. Regards, Andreas >=20 > and what is the status of "device_add x86_64-cpu-socket" ? >=20 > after that, I think we can do somethings to help you to achieve your id= eas. >=20 > Thanks, > Chen >=20 >> >>> Could you please help to review it? >> Will get to it Friday earliest. >> >> Regards, >> Andreas >> >=20 --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)