From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQvNl-0003IB-Js for qemu-devel@nongnu.org; Thu, 26 Feb 2015 05:09:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQvNi-00042h-Bq for qemu-devel@nongnu.org; Thu, 26 Feb 2015 05:09:25 -0500 Received: from [59.151.112.132] (port=41104 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQvNh-00042A-PL for qemu-devel@nongnu.org; Thu, 26 Feb 2015 05:09:22 -0500 Message-ID: <54EEEF3C.1020903@cn.fujitsu.com> Date: Thu, 26 Feb 2015 18:02:36 +0800 From: Chen Fan MIME-Version: 1.0 References: <54EBD30C.1040902@cn.fujitsu.com> <54ECAD4D.9030506@suse.de> <54ED9CC4.90102@cn.fujitsu.com> <54EEE8E0.40301@suse.de> In-Reply-To: <54EEE8E0.40301@suse.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 00/10] cpu: add device_add foo-x86_64-cpu support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?windows-1252?Q?Andreas_F=E4rber?= , Gu Zheng Cc: Zhu Guihua , Bharata B Rao , qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, anshul.makkar@profitbricks.com, imammedo@redhat.com On 02/26/2015 05:35 PM, Andreas F=E4rber wrote: > Hi, > > Am 25.02.2015 um 10:58 schrieb Chen Fan: >> On 02/25/2015 12:56 AM, Andreas F=E4rber wrote: >>> Am 24.02.2015 um 02:25 schrieb Gu Zheng: >>>> The issues you commented in the previous version have been fixed in >>>> this one. >>> What I have repeatedly rejected is "device_add foo-x86_64-cpu". This is >>> still in 00/10 and 09/10. Most of the actual changes however do look to >>> be going in the right direction of making 'realize' work as expected fo= r >>> foo-x86_64-cpu. >>> >>> As for the socket-based device_add I mentioned, I had pushed a work >>> branch qom-cpu-x86 and had some off-list discussions for some of the >>> other architectures but did not submit it as an RFC yet. What I am stil= l >>> working on is dynamic properties to allocate cores (threads TBD) for >>> "device_add x86_64-cpu-socket,cores=3Dn". >> Can you explain all your thoughts about cpu hotplug feature with >> socket-based, >> or how goals do you want to see? > Basically I am implementing Anthony's suggestion from a year or two > back, that is moving towards using real building blocks such as > Xeon-E5-4242 as shortcut for a 6-core, 2-HT device, ultimately replacing > -cpu. Think of what can be plugged in real servers - a socket is atomic > in reality, you can't add cores or hyperthreads dynamically. And the QOM > realize model then forces me to use child<> properties inside the socket > object for consistent recursive processing. yes, I agree with you. but the existed command 'cpu-add' is adding one logic processor each time. it will cause compatibility with the socket-based cpu device. and what do you think to solve this problem ? Thanks, Chen > > Regards, > Andreas > >> and what is the status of "device_add x86_64-cpu-socket" ? >> >> after that, I think we can do somethings to help you to achieve your ide= as. >> >> Thanks, >> Chen >> >>>> Could you please help to review it? >>> Will get to it Friday earliest. >>> >>> Regards, >>> Andreas >>> >