Re: [Qemu-devel] [PATCH] [POWERPC] display cpu id dump state

[Alexander Graf <agraf@suse.de>]

On 25.02.15 10:39, Fabien Chouteau wrote:
> From: Tristan Gingold <gingold@adacore.com>
> 
> 
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>

Same nit here - please always provide a commit message stating your
rationale. I can guess (debugging SMP guests), but it's nicer when you
can look through the logs and there's no need to guess.


Alex

> ---
>  target-ppc/translate.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 88c18e3..2a78e99 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -11214,8 +11214,9 @@ void ppc_cpu_dump_state(CPUState *cs, FILE *f, fprintf_function cpu_fprintf,
>      int i;
>  
>      cpu_fprintf(f, "NIP " TARGET_FMT_lx "   LR " TARGET_FMT_lx " CTR "
> -                TARGET_FMT_lx " XER " TARGET_FMT_lx "\n",
> -                env->nip, env->lr, env->ctr, cpu_read_xer(env));
> +                TARGET_FMT_lx " XER " TARGET_FMT_lx " CPU#%d\n",
> +                env->nip, env->lr, env->ctr, cpu_read_xer(env),
> +                cs->cpu_index);
>      cpu_fprintf(f, "MSR " TARGET_FMT_lx " HID0 " TARGET_FMT_lx "  HF "
>                  TARGET_FMT_lx " idx %d\n", env->msr, env->spr[SPR_HID0],
>                  env->hflags, env->mmu_idx);
>