From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42822)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1YQxOB-0000I6-0T
	for qemu-devel@nongnu.org; Thu, 26 Feb 2015 07:17:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1YQxO7-0006gJ-Jf
	for qemu-devel@nongnu.org; Thu, 26 Feb 2015 07:17:58 -0500
Message-ID: <54EF0EF1.1010000@suse.de>
Date: Thu, 26 Feb 2015 13:17:53 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1424857165-26277-1-git-send-email-chouteau@adacore.com>
In-Reply-To: <1424857165-26277-1-git-send-email-chouteau@adacore.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] [POWERPC] display cpu id dump state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>, qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: Tristan Gingold <gingold@adacore.com>



On 25.02.15 10:39, Fabien Chouteau wrote:
> From: Tristan Gingold <gingold@adacore.com>
> 
> 
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>

Same nit here - please always provide a commit message stating your
rationale. I can guess (debugging SMP guests), but it's nicer when you
can look through the logs and there's no need to guess.


Alex

> ---
>  target-ppc/translate.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 88c18e3..2a78e99 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -11214,8 +11214,9 @@ void ppc_cpu_dump_state(CPUState *cs, FILE *f, fprintf_function cpu_fprintf,
>      int i;
>  
>      cpu_fprintf(f, "NIP " TARGET_FMT_lx "   LR " TARGET_FMT_lx " CTR "
> -                TARGET_FMT_lx " XER " TARGET_FMT_lx "\n",
> -                env->nip, env->lr, env->ctr, cpu_read_xer(env));
> +                TARGET_FMT_lx " XER " TARGET_FMT_lx " CPU#%d\n",
> +                env->nip, env->lr, env->ctr, cpu_read_xer(env),
> +                cs->cpu_index);
>      cpu_fprintf(f, "MSR " TARGET_FMT_lx " HID0 " TARGET_FMT_lx "  HF "
>                  TARGET_FMT_lx " idx %d\n", env->msr, env->spr[SPR_HID0],
>                  env->hflags, env->mmu_idx);
>