From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQy1R-0007pf-56 for qemu-devel@nongnu.org; Thu, 26 Feb 2015 07:58:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQy1N-0004wI-FK for qemu-devel@nongnu.org; Thu, 26 Feb 2015 07:58:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQy1N-0004vp-96 for qemu-devel@nongnu.org; Thu, 26 Feb 2015 07:58:29 -0500 Message-ID: <54EF1850.5050002@redhat.com> Date: Thu, 26 Feb 2015 13:57:52 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1424880159-29348-1-git-send-email-alex.bennee@linaro.org> <1424880159-29348-2-git-send-email-alex.bennee@linaro.org> In-Reply-To: <1424880159-29348-2-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/6] target-arm: kvm: save/restore mp state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= , qemu-devel@nongnu.org Cc: Peter Maydell , kvm@vger.kernel.org, marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org On 25/02/2015 17:02, Alex Benn=C3=A9e wrote: > +#if defined CONFIG_KVM > + { > + .name =3D "mp_state", > + .version_id =3D 0, > + .size =3D sizeof(uint32_t), > + .info =3D &vmstate_mpstate, > + .flags =3D VMS_SINGLE, > + .offset =3D 0, > + }, > +#endif This makes TCG migration state incompatible depending on whether QEMU was built on ARM or x86. You can instead add a subsection, and mark it as needed only iff kvm_enabled(). Paolo > { > .name =3D "cpsr",