From: Paolo Bonzini <pbonzini@redhat.com>
To: Max Reitz <mreitz@redhat.com>,
Wen Congyang <wency@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Gonglei <arei.gonglei@huawei.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: Re: [Qemu-devel] [RFC PATCH 07/14] NBD client: implement block driver interfaces for block replication
Date: Thu, 26 Feb 2015 15:08:03 +0100 [thread overview]
Message-ID: <54EF28C3.9080008@redhat.com> (raw)
In-Reply-To: <54EB9E8B.8070300@redhat.com>
On 23/02/2015 22:41, Max Reitz wrote:
>>
>> }
>> +static int nbd_start_replication(BlockDriverState *bs, int mode)
>> +{
>> + BDRVNBDState *s = bs->opaque;
>> + Error *local_err = NULL;
>> + int ret;
>> +
>> + /*
>> + * TODO: support COLO_SECONDARY_MODE if we allow secondary
>> + * QEMU becoming primary QEMU.
>> + */
>> + if (mode != COLO_PRIMARY_MODE) {
>> + return -1;
>
> Once again, I'd like -ENOTSUP more (or -EINVAL or whatever you prefer).
Using the Error API is the right thing to do here.
Paolo
next prev parent reply other threads:[~2015-02-26 14:08 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 3:07 [Qemu-devel] [RFC PATCH 00/14] Block replication for continuous checkpoints Wen Congyang
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description Wen Congyang
2015-02-12 7:21 ` Fam Zheng
2015-02-12 7:40 ` Wen Congyang
2015-02-12 8:44 ` Fam Zheng
2015-02-12 9:33 ` Wen Congyang
2015-02-12 9:44 ` Fam Zheng
2015-02-12 10:11 ` Wen Congyang
2015-02-12 10:26 ` famz
2015-02-13 5:09 ` Wen Congyang
2015-02-13 7:01 ` Fam Zheng
2015-02-13 20:29 ` John Snow
2015-03-03 7:53 ` Wen Congyang
2015-03-03 7:59 ` Fam Zheng
2015-03-03 12:12 ` Wen Congyang
2015-03-11 6:44 ` Wen Congyang
2015-03-11 6:49 ` Fam Zheng
2015-03-11 7:01 ` Wen Congyang
2015-03-11 7:04 ` Fam Zheng
2015-03-11 7:12 ` Wen Congyang
2015-03-13 9:01 ` Wen Congyang
2015-03-13 9:05 ` Fam Zheng
2015-03-16 6:19 ` Wen Congyang
2015-03-25 12:41 ` Paolo Bonzini
2015-02-12 9:36 ` Hongyang Yang
2015-02-12 9:46 ` Fam Zheng
2015-02-24 7:50 ` Wen Congyang
2015-02-25 2:46 ` Fam Zheng
2015-02-25 8:36 ` Wen Congyang
2015-02-25 8:58 ` Fam Zheng
2015-02-25 9:58 ` Wen Congyang
2015-02-26 6:38 ` Wen Congyang
2015-02-26 8:44 ` Fam Zheng
2015-02-26 9:07 ` Wen Congyang
2015-02-26 10:02 ` Fam Zheng
2015-02-27 2:27 ` Wen Congyang
2015-02-27 2:32 ` Fam Zheng
2015-02-25 8:11 ` Wen Congyang
2015-02-25 8:18 ` Fam Zheng
2015-02-25 9:10 ` Wen Congyang
2015-02-25 9:45 ` Fam Zheng
2015-03-04 16:35 ` Dr. David Alan Gilbert
2015-03-05 1:03 ` Wen Congyang
2015-03-05 19:04 ` Dr. David Alan Gilbert
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 02/14] quorom: add a new read pattern Wen Congyang
2015-02-12 6:42 ` Gonglei
2015-02-23 20:36 ` Max Reitz
2015-02-23 21:56 ` Eric Blake
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 03/14] quorum: ignore 0-length child Wen Congyang
2015-02-23 20:43 ` Max Reitz
2015-02-24 2:33 ` Wen Congyang
2015-03-18 5:29 ` Wen Congyang
2015-03-18 12:57 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 04/14] Add new block driver interfaces to control disk replication Wen Congyang
2015-02-23 20:57 ` Max Reitz
2015-02-23 21:58 ` Eric Blake
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 05/14] quorom: implement block driver interfaces for block replication Wen Congyang
2015-02-23 21:22 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server later Wen Congyang
2015-02-23 21:31 ` Max Reitz
2015-02-25 2:23 ` Wen Congyang
2015-02-25 14:22 ` Max Reitz
2015-02-26 14:07 ` Paolo Bonzini
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 07/14] NBD client: implement block driver interfaces for block replication Wen Congyang
2015-02-23 21:41 ` Max Reitz
2015-02-26 14:08 ` Paolo Bonzini [this message]
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 08/14] block: add a new API to create a hidden BlockBackend Wen Congyang
2015-02-23 21:48 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 09/14] block: give backing image its own BlockBackend Wen Congyang
2015-02-23 21:53 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 10/14] allow the backing image access the origin BlockDriverState Wen Congyang
2015-02-23 22:01 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 11/14] allow writing to the backing file Wen Congyang
2015-02-23 22:03 ` Max Reitz
2015-02-26 14:15 ` Paolo Bonzini
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 12/14] Add disk buffer for block replication Wen Congyang
2015-02-23 22:27 ` Max Reitz
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 13/14] COW: move cow interfaces to a seperate file Wen Congyang
2015-02-12 3:07 ` [Qemu-devel] [RFC PATCH 14/14] COLO: implement a new block driver Wen Congyang
2015-02-23 22:35 ` Max Reitz
2015-02-18 16:26 ` [Qemu-devel] [RFC PATCH 00/14] Block replication for continuous checkpoints Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EF28C3.9080008@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=kwolf@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).