From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR5MC-00086H-IZ for qemu-devel@nongnu.org; Thu, 26 Feb 2015 15:48:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YR5M9-000371-C3 for qemu-devel@nongnu.org; Thu, 26 Feb 2015 15:48:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR5M9-00036u-2E for qemu-devel@nongnu.org; Thu, 26 Feb 2015 15:48:25 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1QKmNYv005127 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 26 Feb 2015 15:48:24 -0500 Message-ID: <54EF8696.4000706@redhat.com> Date: Thu, 26 Feb 2015 13:48:22 -0700 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Di1uuOLnl6ffGtnShb2cA747N8aboIfor" Subject: Re: [Qemu-devel] [PATCH] hmp: info spice: Show string channel name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson , qemu-devel@nongnu.org Cc: Luiz Capitulino , Gerd Hoffmann , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Di1uuOLnl6ffGtnShb2cA747N8aboIfor Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/26/2015 12:02 PM, Cole Robinson wrote: > Useful for debugging. >=20 > https://bugzilla.redhat.com/show_bug.cgi?id=3D822418 > Signed-off-by: Cole Robinson > --- > hmp.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/hmp.c b/hmp.c > index 735097c..93fd5cd 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -545,6 +545,11 @@ void hmp_info_spice(Monitor *mon, const QDict *qdi= ct) > { > SpiceChannelList *chan; > SpiceInfo *info; > + const char *channel_name; > + /* String representations of SPICE_CHANNEL_* enum */ > + const char * const channel_names[] =3D {"main", "display", "input"= , "cursor", > + "playback", "record", "tunnel", "smartcard", "usbredir", "port= ", > + "webdav"}; > =20 Hmm. I wonder if we should have a QAPI enum for this, instead of open-coding it here. But as this is already a strict improvement, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Di1uuOLnl6ffGtnShb2cA747N8aboIfor Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU74aWAAoJEKeha0olJ0NqwJoH/iKN09dyi5kHgjhb446X9tFD eahMvfMkN4ujEW2OSxUlc8LbGqd7fuPc8ojxqqca3ne/nU4wGaaYmF9wKaOLeyKe otIDyuLsQnLh37oaNx6MK8/KmBB/bzkLw6gJBVW8aYJg1CtkaHojrlql/FWothi6 v5M5Px8dt3hAE6XkPjXuh2Sfj6hmm98c2PcQYKOxipkChtm0u7kSGcekfbVQAwFI DmAt+NaqKkBkhaVM1JyWdwZ21SjMUAuSuU/3VxXxEldRJG7O9IMzTabFUFXn/Ul2 f/mmHLmCU2D+9hDp+g9g1Z0h69AsRDzfB1ZFkdD62rzU7HaoaFOOvE7Lji5GLvA= =fmUC -----END PGP SIGNATURE----- --Di1uuOLnl6ffGtnShb2cA747N8aboIfor--