From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR9eY-000882-Ac for qemu-devel@nongnu.org; Thu, 26 Feb 2015 20:23:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YR9eT-0000H5-DZ for qemu-devel@nongnu.org; Thu, 26 Feb 2015 20:23:42 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:57524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR9eS-0000Gh-KF for qemu-devel@nongnu.org; Thu, 26 Feb 2015 20:23:37 -0500 Message-ID: <54EFC706.20801@huawei.com> Date: Fri, 27 Feb 2015 09:23:18 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1424937492-10720-1-git-send-email-zhang.zhanghailiang@huawei.com> <54EF3A9A.3000100@redhat.com> In-Reply-To: <54EF3A9A.3000100@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC] migration: Convert 'status' of MigrationInfo to use an enum type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: hangaohuai@huawei.com, quintela@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, amit.shah@redhat.com, peter.huangpeng@huawei.com, dgilbert@redhat.com On 2015/2/26 23:24, Eric Blake wrote: > On 02/26/2015 12:58 AM, zhanghailiang wrote: >> The original 'status' is an open-coded 'str' type, convert it to use an >> enum type. >> This conversion is backwards compatible, better documented and >> more convenient for future extensibility. >> >> In addition, Fix a typo for qapi-schema.json: comppleted -> completed >> >> Signed-off-by: zhanghailiang >> --- > > >> +++ b/qapi-schema.json >> @@ -411,18 +411,42 @@ >> 'overflow': 'int' } } >> >> ## >> +# @MigState: >> +# >> +# An enumeration of migration status. >> +# >> +# @failed: some error occurred during migration process. (since 0.14.0) >> +# >> +# @none: no migration has happened ever. > > s/happened ever/ever happened/ > >> +# >> +# @setup: migration process has been initiated. (since 0.14.0) >> +# >> +# @cancelling: in the process of cancelling migration. (since 2.0) > > It's weird to advertise this enum value when the code goes to lengths to > hide it behind 'active', but I guess it's okay. > Hmm, yes, this state is only used internally, and will return 'active' to user instead, it is a problem left over by history, which introduced by 51cf4c1a commit. It is no side effect, maybe a NOTE should be added. >> +# >> +# @cancelled: cancelling migration is finished. (since 0.14.0) >> +# >> +# @active: in the process of doing migration. (since 0.14.0) >> +# >> +# @completed: migration is finished. (since 0.14.0) >> +# >> +# Since: 2.3 > > It's weird to see various enum values stating (since xyz) that is older > than 2.3. Generally, we only use that for an enum value that is newer > than the enumeration. I'd be just fine if you got rid of all of the > per-value '(since xyz)' strings. > OK, will fix in v2. > Otherwise, looks good to me. > Thanks. zhanghailiang