From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60078)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YRLyt-0002Gb-4B
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 09:33:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YRLyo-0004h4-1k
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 09:33:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52320)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YRLyn-0004gx-Rr
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 09:33:26 -0500
Message-ID: <54F08032.8070401@redhat.com>
Date: Fri, 27 Feb 2015 09:33:22 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1424687012-18524-1-git-send-email-kraxel@redhat.com>		
	<1424687012-18524-7-git-send-email-kraxel@redhat.com>		
	<54EF44F1.1090507@redhat.com>	
	<1425035430.20883.44.camel@nilsson.home.kraxel.org>	
	<54F07D31.2000100@redhat.com>
	<1425047464.20883.60.camel@nilsson.home.kraxel.org>
In-Reply-To: <1425047464.20883.60.camel@nilsson.home.kraxel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu
 core code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, "Michael S. Tsirkin" <mst@redhat.com>

On 2015-02-27 at 09:31, Gerd Hoffmann wrote:
>>>>> +    if (t2d.offset || t2d.r.x || t2d.r.y ||
>>>>> +        t2d.r.width != pixman_image_get_width(res->image)) {
>>>> Will this work with stride != t2d.r.width * bpp?
>>> Those cases should take the if branch above and loop over all lines to
>>> handle it correctly.
>> Exactly, but it looks like to me that it doesn't (at least not always).
> Ah, you mean we should better check something like
>
>    t2d.r.width * bpp != pixman_image_get_stride() ?
>
> That should check exactly the same thing as we never create resources
> with extra padding where width * bpp != stride.

Ah, you're right, I missed that. Very well then.

Max