From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRM5u-00014T-Aj for qemu-devel@nongnu.org; Fri, 27 Feb 2015 09:40:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRM5o-0006y3-RL for qemu-devel@nongnu.org; Fri, 27 Feb 2015 09:40:46 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56333 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRM5o-0006xa-36 for qemu-devel@nongnu.org; Fri, 27 Feb 2015 09:40:40 -0500 Message-ID: <54F081E6.1050209@suse.de> Date: Fri, 27 Feb 2015 15:40:38 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1424983069-14080-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1424983069-14080-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/4] cpu: Make cpu_init() return QOM object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Blue Swirl , Riku Voipio , qemu-devel@nongnu.org Hi Eduardo, Am 26.02.2015 um 21:37 schrieb Eduardo Habkost: > This series changes cpu_init() to return a CPU QOM object, and changes = existing > arch-specific code to use the corresponding arch-specific function inst= ead of > cpu_init(). >=20 > With this, the only remaining users of cpu_init() are linux-user and bs= d-user. >=20 > Eduardo Habkost (4): > target-unicore32: Make uc32_cpu_init() return UniCore32CPU > m68k: Use cpu_m68k_init() > unicore32: Use uc32_cpu_init() This part looks good to me. At the time, I propagated *CPU only for those machines that needed it for function calls or field accesses. > cpu: Make cpu_init() return QOM object As for this patch, the Coccinelle based approach looks cool! However I would like to give this a bit more thought as to whether 1) this causes churn with regards to the next steps I outlined, and 2) whether more simplifications can be done while at it. Could be done as follow-ups. Let's also keep in mind that target-tilegx patches are on the list. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)