[Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore

[Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore

[Cole Robinson]

Rather than track it in the toplevel gitignore

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 .gitignore                    | 1 -
 tests/qemu-iotests/.gitignore | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index 090f974..e32a584 100644
--- a/.gitignore
+++ b/.gitignore
@@ -109,4 +109,3 @@ cscope.*
 tags
 TAGS
 *~
-/tests/qemu-iotests/common.env
diff --git a/tests/qemu-iotests/.gitignore b/tests/qemu-iotests/.gitignore
index 0541f80..0711cbd 100644
--- a/tests/qemu-iotests/.gitignore
+++ b/tests/qemu-iotests/.gitignore
@@ -1,5 +1,6 @@
 check.log
 check.time
+common.env
 *.out.bad
 *.notrun
 socket_scm_helper
-- 
2.1.0

[Qemu-devel] [PATCH] gitignore: Ignore new tests

[Cole Robinson]

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 tests/.gitignore | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/.gitignore b/tests/.gitignore
index e2e4957..0dcb618 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -5,6 +5,7 @@ check-qjson
 check-qlist
 check-qstring
 check-qom-interface
+rcutorture
 test-aio
 test-bitops
 test-coroutine
@@ -26,6 +27,7 @@ test-qmp-input-strict
 test-qmp-input-visitor
 test-qmp-marshal.c
 test-qmp-output-visitor
+test-rcu-list
 test-rfifolock
 test-string-input-visitor
 test-string-output-visitor
@@ -33,6 +35,7 @@ test-thread-pool
 test-throttle
 test-visitor-serialization
 test-vmstate
+test-write-threshold
 test-x86-cpuid
 test-xbzrle
 *-test
-- 
2.1.0

Re: [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

On 02/27/2015 08:21 AM, Cole Robinson wrote:
> Rather than track it in the toplevel gitignore
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  .gitignore                    | 1 -
>  tests/qemu-iotests/.gitignore | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)

I think that the fact that we have multiple .gitignore is confusing, and
would personally lean towards a patch that consolidates ALL ignores into
a single top-level file, instead of having to hunt multiple files for
patterns.  But my opinion on this matter is not strong enough for me to
provide a patch at this time...

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore

[Michael Tokarev]

27.02.2015 19:33, Eric Blake wrote:
> On 02/27/2015 08:21 AM, Cole Robinson wrote:
>> Rather than track it in the toplevel gitignore
>>
>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>> ---
>>  .gitignore                    | 1 -
>>  tests/qemu-iotests/.gitignore | 1 +
>>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> I think that the fact that we have multiple .gitignore is confusing, and
> would personally lean towards a patch that consolidates ALL ignores into
> a single top-level file, instead of having to hunt multiple files for
> patterns.  But my opinion on this matter is not strong enough for me to
> provide a patch at this time...

Since tests/ is kind of special because it generates so many
various files in there, I think it is reasonable to have separate
.gitignore files in there.

Thanks,

/mjt

Re: [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore

[Michael Tokarev]

Applied both to -trivial, thank you!

/mjt