From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRNrE-0005kL-DC for qemu-devel@nongnu.org; Fri, 27 Feb 2015 11:33:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRNr9-0002jV-El for qemu-devel@nongnu.org; Fri, 27 Feb 2015 11:33:44 -0500 Message-ID: <54F09C57.3030702@redhat.com> Date: Fri, 27 Feb 2015 09:33:27 -0700 From: Eric Blake MIME-Version: 1.0 References: <60b9a8741264d4fc7042ae560ea859cd62babd1e.1425050482.git.crobinso@redhat.com> In-Reply-To: <60b9a8741264d4fc7042ae560ea859cd62babd1e.1425050482.git.crobinso@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hqwACqSmeIbmehPtXr9H5jnK9v54Clu0l" Subject: Re: [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson , qemu-devel@nongnu.org Cc: qemu-trivial This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hqwACqSmeIbmehPtXr9H5jnK9v54Clu0l Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/27/2015 08:21 AM, Cole Robinson wrote: > Rather than track it in the toplevel gitignore >=20 > Signed-off-by: Cole Robinson > --- > .gitignore | 1 - > tests/qemu-iotests/.gitignore | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) I think that the fact that we have multiple .gitignore is confusing, and would personally lean towards a patch that consolidates ALL ignores into a single top-level file, instead of having to hunt multiple files for patterns. But my opinion on this matter is not strong enough for me to provide a patch at this time... --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hqwACqSmeIbmehPtXr9H5jnK9v54Clu0l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU8JxXAAoJEKeha0olJ0NqdhMH/A1ZLxs/1MeE2z9NCSXRYfKC 2+HzcfpXpS3B3ELmAWT4ikIaURZ3YDxh4g1EixKCBnLxpEcmwIlFz2SvLBKgBSe7 exlrHSL3phOPNJexXrg0M64VbmsDWl9LqIBsCqB09of3ZcFzxp2miZSXuQAhfUoD hH0f+rg/1GlywRKktkdIJ3M9W7BRd3hXLZl8GF0qP/To2WyjzN7o6gGeBgQGHGBw MoQ/UWKvNwQpUvnrjgdUz/mmQqQnYdo8zDx6If48O6/5+DHtK/ytpcArAqUAOzLy QmRcswqYKUfV6S42NwZE18LY+b0rfS4GFm+f8Q5hAXPzBlZjAmqNbO3ZPkeP/hk= =+vy8 -----END PGP SIGNATURE----- --hqwACqSmeIbmehPtXr9H5jnK9v54Clu0l--